Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

actually return multiple arguments using std::pair instead of just returning the first one... #16

Closed
zdevito opened this issue Jun 8, 2017 · 1 comment
Closed

actually return multiple arguments using std::pair instead of just returning the first one... #16

zdevito opened this issue Jun 8, 2017 · 1 comment

Comments

@zdevito
Copy link
Owner

zdevito commented Jun 8, 2017

actually return multiple arguments using std::pair instead of just returning the first one...
arg = option['arguments'][ret['arguments'][0]]
@zdevito
Copy link
Owner Author

zdevito commented Jun 9, 2017

4a01406 adds this

@zdevito zdevito closed this as completed Jun 9, 2017
zdevito pushed a commit that referenced this issue Sep 11, 2018
@facebook-github-bot
Cleanup byte swapping utilities to generate optimal code on the platf…
0b78ae8 
…orms we care about. (pytorch#11394)

Summary:
While the use of memcpy as part of the byte swapping sequence looks funky, all major
compilers recognize and optimize this pattern reliably, resulting in essentially
optimal code generation.

For example, decodeUInt32LE goes from this on iOS arm64:
>         ldrb    w8, [x0, #3]
>         ldrb    w9, [x0, #2]
>         bfi     w8, w9, #8, #8
>         ldrb    w9, [x0, #1]
>         bfi     w8, w9, #16, #8
>         ldrb            w9, [x0]
>         bfi     w8, w9, #24, #8
>         mov      x0, x8
>         ret

To this:
>         ldr             w8, [x0]
>         rev     w0, w8
>         ret
Pull Request resolved: pytorch#11394

Reviewed By: SsnL

Differential Revision: D9728659

Pulled By: resistor

fbshipit-source-id: 9afbd4adfad1d1fb7b01f1179e6707ee21fa726f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zdevito