Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #395 #397

Merged
merged 1 commit into from
Apr 8, 2023
Merged

Fix #395 #397

merged 1 commit into from
Apr 8, 2023

Conversation

Freed-Wu
Copy link
Contributor

Description

Create ._zinit/.gitignore which content is '*' for every plugin.

Motivation and Context

zinit create ._zinit to store some metadata. However, this metadata should not
be added to git.

Related Issue(s)

Fix #395.

I am not sure if
https://github.com/zdharma-continuum/zinit/blob/main/share/template-plugin/zsh.gitignore#L12
should be removed. Maybe we should support old zinit? And I think this file
should be pushed to https://github.com/github/gitignore/ to let more zsh
plugin developers use.

How Has This Been Tested?

I have tested it can work for me.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions github-actions bot added the zinit label Oct 16, 2022
@vladdoster
Copy link
Member

I understand the reason, but I can't think of a situation where ._zinit would be added to git?

@Freed-Wu
Copy link
Contributor Author

a situation where ._zinit would be added to git

Exist, such as user use ~/.local/share/zinit/plugins/XXX to develop their own
plugin and use git to VCS.

@vladdoster
Copy link
Member

Can you rebase your branch onto main so the checks will pass?

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Nov 1, 2022

OK.

@Freed-Wu
Copy link
Contributor Author

Seems that some test failed.

@Freed-Wu
Copy link
Contributor Author

What happened? @vladdoster

 Downloading alist-org/alist…

gh-r: failed to find the correct GitHub release asset to download.

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Feb 8, 2023

What happened? @vladdoster

 Downloading alist-org/alist…

gh-r: failed to find the correct GitHub release asset to download.

Is it due to network problem? Can anyone rerun the test to take a look?

@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Apr 4, 2023

@vladdoster @pschmitt

@pschmitt
Copy link
Member

pschmitt commented Apr 4, 2023

@vladdoster @pschmitt

Don't. Fix the ci instead.

@vladdoster
Copy link
Member

@Freed-Wu,

Your branch is out of date. Rebase your branch using the zdharma-continuum main branch.

@vladdoster
Copy link
Member

@Freed-Wu,

I went ahead and rebased your branch.

@vladdoster
Copy link
Member

@Freed-Wu,

Don't worry about the numerous commits. I'll merge this once unit tests pass and will regenerate the docs in a separate PR.

Thanks again for your PR :^)

@Freed-Wu
fix: add .gitignore for zsh plugins
a4ce2b5 
close #395
fix wrong lines of zsdoc
@github-actions github-actions bot added the docs label Apr 4, 2023
@Freed-Wu
Copy link
Contributor Author

Freed-Wu commented Apr 4, 2023

All checks have passed.

@pschmitt pschmitt merged commit da7d018 into zdharma-continuum:main Apr 8, 2023
5 checks passed
vladdoster added a commit that referenced this pull request Apr 8, 2023
@Freed-Wu @vladdoster
fix: add .gitignore with '*' pattern in a plugins ._zinit directory (#…
a8a6382 
…397)

Zinit creates a directory named `._zinit` to store metadata. However, this metadata should not
be added to git.

Closes #395

Signed-off-by: wzy <32936898+Freed-Wu@users.noreply.github.com>
Co-authored-by: vladislav doster <10052309+vladdoster@users.noreply.github.com>
vladdoster added a commit that referenced this pull request Apr 8, 2023
@Freed-Wu @vladdoster
fix: add .gitignore with '*' pattern in a plugins ._zinit/ direct…
fccb508 
…ory (#397)

Zinit creates a directory named `._zinit` to store metadata. However, this
metadata should not be added to git.

Closes #395

Signed-off-by: wzy <32936898+Freed-Wu@users.noreply.github.com>
Co-authored-by: Vladislav Doster <mvdoster@gmail.com>
github-actions bot pushed a commit that referenced this pull request May 4, 2023
@vladdoster
release: v3.10.0 → v3.11.0
879d889 
# [3.11.0](v3.10.0...v3.11.0) (2023-05-04)

### Bug Fixes

* add `.gitignore` with '*' pattern in a plugins `._zinit/` directory ([#397](#397)) ([fccb508](fccb508)), closes [#395](#395)
* broken update command ([336ca85](336ca85))
* cleanup style, naming, and completion ([6c82d67](6c82d67))
* compile and completion log messages ([c4446da](c4446da))
* csearch ignores lua files ([4d1840b](4d1840b))
* makefile clean target less verbose ([3396f5e](3396f5e))
* pin git-mkver gh-r test to v.1.2.2 ([a05cc1a](a05cc1a))
* pin git-mkver unit test to v1.2.2 ([08f02e0](08f02e0))
* regenerate docs ([e0177e2](e0177e2))

### Features

* expand gh-r zunit tests ([c323116](c323116))
* refactor debug commands ([930b25e](930b25e))
* refactor ls, list, and loaded commands ([a865907](a865907))
@p-linnane p-linnane mentioned this pull request May 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pschmitt pschmitt pschmitt approved these changes

@alichtman alichtman Awaiting requested review from alichtman alichtman is a code owner

@vladdoster vladdoster Awaiting requested review from vladdoster vladdoster is a code owner

Assignees
No one assigned
Labels
docs zinit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat]: generate .gitignore in ._zinit
3 participants
@Freed-Wu @vladdoster @pschmitt