Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gh-r linux regex & gh-r zunit tests #564

Merged
merged 3 commits into from
Aug 30, 2023
Merged

fix: gh-r linux regex & gh-r zunit tests #564

merged 3 commits into from
Aug 30, 2023

Conversation

vladdoster
Copy link
Member

@vladdoster vladdoster commented Aug 20, 2023

Description

  • Update gh-r regex to avoid x86_64 GNU systems selecting arm64 binary GNU
  • Fixes silently failing gh-r zunit tests

Closes #539

Before

Screenshot 2023-08-20 at 08 23 41

After

Screenshot 2023-08-20 at 08 19 29

Related Issue(s)

Closes #539

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
actions-user and others added 2 commits August 30, 2023 02:28
Signed-off-by: GitHub Actions <actions@github.com>
@vladdoster vladdoster merged commit 207ab9f into main Aug 30, 2023
5 checks passed
@vladdoster vladdoster deleted the fix/navi-test branch August 30, 2023 04:33
github-actions bot pushed a commit that referenced this pull request Aug 30, 2023
# [3.12.0](v3.11.0...v3.12.0) (2023-08-30)

### Bug Fixes

* build container for tagged releases ([f933dc0](f933dc0))
* gh-r linux regex & gh-r zunit tests ([#564](#564)) ([207ab9f](207ab9f))
* gh-r zunit tests ([#561](#561)) ([97b087e](97b087e))
* Ignore .yaml and .py files when installing completions ([#528](#528)) ([113cfc4](113cfc4))
* jq has moved from stedolan/jq to jqlang/jq ([#530](#530)) ([de85908](de85908))
* math expression in plugins command ([#559](#559)) ([68a6b42](68a6b42))
* pin fclones version to v0.31.0 ([497d519](497d519))
* quote parens so that they aren't used as globs ([#549](#549)) ([1375adf](1375adf))
* self-update check for updates ([#562](#562)) ([b456a2d](b456a2d))
* update gomi repo owner ([#568](#568)) ([19ca2dc](19ca2dc))

### Features

* build container with zsh 5.9 ([#525](#525)) ([238e843](238e843))
@github-actions
Copy link

🎉 This PR is included in version 3.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@vladdoster vladdoster mentioned this pull request Aug 30, 2023
7 tasks
filtered=( ${list[@]:#(#i)*${~junk}*} ) && (( $#filtered > 0 )) && list=( ${filtered[@]} )

local -a array=( $(print -rm "*($(arch)|${VENDOR}|)*~^*(${parts[1]}|${(L)$(uname)})*" $list[@]) )

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

arch doesn't seem to be a part of coreutils (9.3-1) on Arch Linux, though it is available in the AUR as coreutils-arch. A more universal option would be uname -m, which has the exact same output as arch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: gh-r linux wrong arch binary -- downloads aarch64 instead of x86_64
3 participants