Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect delete flags after positional arguments #587

Merged
merged 1 commit into from
Oct 29, 2023

Conversation

vladdoster
Copy link
Member

Description

zinit delete option flags can go before or after positional arguments.

Motivation and Context

Screenshot 2023-10-28 at 8 44 36 PM

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@github-actions github-actions bot added the zinit label Oct 29, 2023
@vladdoster vladdoster changed the title fix: respect delete flags after positionals fix: respect delete flags after positional arguments Oct 29, 2023
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
@pschmitt
Copy link
Member

Lgtm

@vladdoster vladdoster merged commit e18f9a7 into main Oct 29, 2023
5 checks passed
@vladdoster vladdoster deleted the fix/delete-flags branch October 29, 2023 08:30
github-actions bot pushed a commit that referenced this pull request Nov 20, 2023
## [3.12.1](v3.12.0...v3.12.1) (2023-11-20)

### Bug Fixes

* container zshelldoc install ([#591](#591)) ([8170753](8170753))
* from'gh-r' skips compile by default ([#590](#590)) ([1f52eee](1f52eee))
* respect delete flags after positional arguments ([#587](#587)) ([e18f9a7](e18f9a7))
* set home dir to test env in gh-r tests ([#582](#582)) ([9b33288](9b33288))
* use $MACHTYPE instead of arch command ([#588](#588)) ([bcf70e8](bcf70e8))
Copy link

🎉 This PR is included in version 3.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants