Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: from'gh-r' skips compile by default #590

Merged
merged 4 commits into from
Nov 20, 2023
Merged

Conversation

vladdoster
Copy link
Member

@vladdoster vladdoster commented Nov 20, 2023

Description

Skip compile if from'gh-r' ice is set unless compile is also set.

Motivation and Context

Old behavior left & New behavior right

Screenshot 2023-11-20 at 04 56 03

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

Skip compile if from'gh-r' ice is set unless compile is also set.

Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
Signed-off-by: Vladislav Doster <mvdoster@gmail.com>
vladdoster and others added 2 commits November 20, 2023 05:41
Signed-off-by: GitHub Actions <actions@github.com>
@vladdoster vladdoster merged commit 1f52eee into main Nov 20, 2023
@vladdoster vladdoster deleted the vladdoster-patch-1 branch November 20, 2023 11:50
github-actions bot pushed a commit that referenced this pull request Nov 20, 2023
## [3.12.1](v3.12.0...v3.12.1) (2023-11-20)

### Bug Fixes

* container zshelldoc install ([#591](#591)) ([8170753](8170753))
* from'gh-r' skips compile by default ([#590](#590)) ([1f52eee](1f52eee))
* respect delete flags after positional arguments ([#587](#587)) ([e18f9a7](e18f9a7))
* set home dir to test env in gh-r tests ([#582](#582)) ([9b33288](9b33288))
* use $MACHTYPE instead of arch command ([#588](#588)) ([bcf70e8](bcf70e8))
Copy link

🎉 This PR is included in version 3.12.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants