Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

Enhancements for #442 #443

Closed
8 tasks done
fkztw opened this issue Jul 7, 2020 · 1 comment · Fixed by #446
Closed
8 tasks done

Enhancements for #442 #443

fkztw opened this issue Jul 7, 2020 · 1 comment · Fixed by #446
Assignees
@fkztw
Labels
feature

Comments

@fkztw
Copy link
Member

fkztw commented Jul 7, 2020 •
edited

  • Testings
  • Update README
  • Not Found error
$ zdict -dt NAER "sdfasdf" 
Query: sdfasdf

Should be not found

/home/m157q/.pyenv/versions/3.6.5/envs/zdict-3.6.5/lib/python3.6/site-packages/urllib3/connectionpool.py:1
004: InsecureRequestWarning: Unverified HTTPS request is being made to host 'terms.naer.edu.tw'. Adding ce
rtificate verification is strongly advised. See: https://urllib3.readthedocs.io/en/latest/advanced-usage.h
tml#ssl-warnings                                                                                          
  InsecureRequestWarning,
  • -dt NAER => -dt naer
    • No need to use uppercase. Lowercase is more convenient.
  • Remove Query:
  • Change title from 國家教育研究院 to 國家教育研究院 - 雙語詞彙、學術名詞暨辭書資訊網
    • More precise.
  • Should not treat QueryError as NotFoundError
@fkztw fkztw self-assigned this Jul 7, 2020
@fkztw fkztw added the feature label Jul 7, 2020
@fkztw fkztw mentioned this issue Jul 7, 2020
Merged
@fkztw
Copy link
Member Author

fkztw commented Jul 7, 2020

20200707_18:58:13
20200707_18:57:40

fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Add Not Found for NAER
7744d8f
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Ignore SSL warnings for NAER
03501b6 
https://terms.naer.edu.tw/ uses an outdated security configuration which
causes the SSL warning.
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] -dt NAER => -dt naer
c47a63e 
Lowercase is more convenient.
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Remove Query: for NAER
7ae05c9 
It's redundant.
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Make NAER title more precise
49492d5
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Should not treat QueryError as NotFoundError
63d2858
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Add testings for NAER
fb3ce93
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Update README for NAER
5160f86
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Set timeout to 60 secs for test_naer.py for CircleCI
36bab99
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Set timeout to 60 secs for test_naer.py for CircleCI
d59129f
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Try to fix SSL error on CircleCI
91ac446
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Try to fix SSL error on CircleCI
9b6842d
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Try to fix SSL error on CircleCI
2c946b9
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Try to fix SSL error on CircleCI
90d6b15
fkztw pushed a commit that referenced this issue Jul 7, 2020
[#443] Try to fix SSL error on CircleCI
f20a560
@fkztw fkztw linked a pull request Jul 7, 2020 that will close this issue
Issue #443 #446
Merged
@fkztw fkztw closed this as completed in #446 Jul 7, 2020
fkztw pushed a commit that referenced this issue Jul 7, 2020
Version 3.6.0
be7547b 
- 9c87f3d Merge pull request #446 from zdict/issue-443
    - f20a560 [#443] Try to fix SSL error on CircleCI
    - 5160f86 [#443] Update README for NAER
    - fb3ce93 [#443] Add testings for NAER
    - 3fb67cd Make unexpected exception message more readable
    - 63d2858 [#443] Should not treat QueryError as NotFoundError
    - 49492d5 [#443] Make NAER title more precise
    - 7ae05c9 [#443] Remove `Query: ` for NAER
    - c47a63e [#443] `-dt NAER` => `-dt naer`
    - 03501b6 [#443] Ignore SSL warnings for NAER
    - 7744d8f [#443] Add Not Found for NAER
- 1d92f43 Merge pull request #444 from zdict/pyup-update-coverage-5.1-to-5.2
    - b933a36 Update coverage from 5.1 to 5.2
- f0dc67d Merge pull request #442 from mlouielu/add-naer-terms
    - 1de8d27 [#442] Fix for flake8
    - 2437d30 Add NAER terms to dictionaries
- 58d0f46 Update requests to 2.24.0 (#439)
- 7bd7823 Update pytest-cov to 2.10.0 (#437)
- f1df120 [#438] Create codeql-analysis.yml (#440)
- eee33c6 [#436] Add "Dependencies scanned by PyUp.io"
- d5b8a03 [.gitignore] Add .python-version for pyenv
- 74843db Update flake8 to 3.8.3 (#435)
- 07f57cb [README] Change command for installing testing deps
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fkztw fkztw

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #443 zdict/zdict
1 participant
@fkztw