Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

[#100] prevent KeyError being caused crash #101

Merged
merged 1 commit into from
Aug 31, 2016
Merged

[#100] prevent KeyError being caused crash #101

merged 1 commit into from
Aug 31, 2016

Conversation

pi314
Copy link
Collaborator

@pi314 pi314 commented Aug 31, 2016 •
edited by fkztw

ref: #100

@coveralls
Copy link

coveralls commented Aug 31, 2016 •
edited

Coverage Status

Coverage remained the same at 83.616% when pulling 9473b4f on issue-100 into e132d31 on master.

@pi314 pi314 merged commit 92eae41 into master Aug 31, 2016
@fkztw
Copy link
Member

fkztw commented Aug 31, 2016

I think we should add an unit test for this.

fkztw pushed a commit that referenced this pull request Aug 31, 2016
[#101] Add unit test for YahooDict of vocabulary 'style'
daf9abc
fkztw pushed a commit that referenced this pull request Aug 31, 2016
Merge pull request #102 from zdict/issue-100
05e5c81 
[#101] Add unit test for YahooDict of vocabulary 'style'
fkztw pushed a commit that referenced this pull request Aug 31, 2016
[zdict-0.9.6]
95cb66f 
+ [#100, #101] Fix a bug in zdict/dictionaires/yahoo.py which will
cause KeyError while dealing with the CSS with example sentences.
thanks @pi314
+ [#102] Add more unit tests for Yahoo Dictionary
in zdict/tests/dictionaires/test_yahoo.py
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pi314 @coveralls @fkztw