Skip to content
This repository has been archived by the owner on Jul 10, 2023. It is now read-only.

[#418] Fix CI problem for pip>=20.1 related to parse_requirements #419

Merged
merged 2 commits into from May 29, 2020
Merged

[#418] Fix CI problem for pip>=20.1 related to parse_requirements #419

merged 2 commits into from May 29, 2020

Conversation

fkztw
Copy link
Member

@fkztw fkztw commented May 16, 2020

No description provided.

@coveralls
Copy link

coveralls commented May 16, 2020 •
edited

Coverage Status

Coverage remained the same at 83.986% when pulling b2edc12 on issue-418 into 559ce89 on master.

@fkztw
Copy link
Member Author

fkztw commented May 16, 2020

ref: AngellusMortis/django_microsoft_auth@77879cf

[#418] Fix parse_requirements() for pip >= 20.1
b2edc12 
pip 20.1 moved `parse_requirements()` to `pip._vendor.pkg_resources`
ref: https://github.com/pypa/pip/blob/1e67c3cc201c3eaf7ac6927954729a01e4c28e45/src/pip/_internal/req/constructors.py#L18

Too many different dependency path for parse_requirements() in different
versions of pip.
Just write a simple parse_requirements() function by ourselves.
@fkztw fkztw changed the title [#418] Fix CI problem for pip==20.1 related to parse_requirements [#418] Fix CI problem for pip>=20.1 related to parse_requirements May 29, 2020
@fkztw fkztw merged commit 1c14af0 into master May 29, 2020
@fkztw fkztw deleted the issue-418 branch May 29, 2020 04:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fkztw @coveralls