Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using repeater module to remove duplicate code #298

Closed
wants to merge 4 commits into from
Closed

Using repeater module to remove duplicate code #298

wants to merge 4 commits into from

Conversation

aman566
Copy link
Collaborator

@aman566 aman566 commented Jun 14, 2020 •
edited
Loading

fixing some of the given modules in #150
Tried implementing the repeater module in admin_scan.

Checklist

  • I have followed the Contributor Guidelines.
  • I have added the relevant documentation.
  • My branch is up-to-date with the upstream master branch.

Changes proposed in this pull request

  • used repeater module to remove duplicate code.
  • Cleaning admin_scan module using repeater module

Your development environment

  • OS: Linux
  • OS Version: Ubuntu 18.04
  • Python Version: 3.6.9

@securestep9
Copy link
Collaborator

securestep9 commented Jun 14, 2020 •
edited
Loading

this PR conflicts with already merged PR#297

@Ali-Razmjoo
Copy link
Collaborator

this can't be supported anymore. modules are yaml #440

@Ali-Razmjoo Ali-Razmjoo closed this Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman566 @securestep9 @Ali-Razmjoo