Set default zoom of webview based on DPI. #1080
Conversation
|
Thank you for the contribution, very interesting! Does this work better on High-DPI screens? What about moving window between screens with different DPI or scaling factors? The list of zoom levels is inspired by what Firefox and Chrome do. Also maintaining specific zoom values should make it easier to save and restore sessions in the future. |
This works better for high dpi screens where the user is using font dpi scaling (vs full screen scaling). Font DPI scaling usually looks better than full screen scaling when scaling by fractional amounts. For full screen scaling (e.g. scaling by 200% using the display control panel), this shouldn't change anything. I'm only talking about in the context of windows, I'm not sure whether windows use DPI based scaling or not (I should probably check).
I'm not familiar with how QT surfaces this information, and I've never had much hope that this works correctly on linux. I think this is somewhat orthogonal to this diff though.
Let me do that then. |
|
Alright I've updated this to apply the DPI based scaling with the zoom-level style scaling. Seems to behave sensibly on linux in KDE5 and Gnome3 when font DPI scaling is used, and when screen-scaling is used. |
|
@yiding thanks, I'll review and test over the weekend. |
|
@yiding could you rebase on top of master? |
Also change `defaultZoomLevel()`'s `const int &` return type to just `int`. Test Plan: On Linux: In KDE, forced DPI to 96 and 120. Restarting the app shows initial webview scaled to 1x and 1.25x respectively. In Gnome 3, use Tweaks to set font scaling to 1.25, restart the app.
|
Thank you! |
Control zoom factor directly rather than using hardcoded zoom levels.
In order to ensure that the webview starts out scaled appropriately to the
current font DPI, we set default zoom level based on current DPI, e.g.:
96 DPI - 100% zoom
120 DPI - 125% zoom
Since this will allow zoom levels beyond the predefined set, I also change the
logic for zooming to simply add or remove 10% to the current scaling.
Note that if we want to still maintain the predefined zoom levels, I can rewrite this to multiply the predefined zoom levels by the zoom level derived from the current DPI.