Improve error message when storage does not exist #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trollixx
approved these changes
Nov 11, 2019
| ui->readOnlyLabel->setVisible(m_isStorageReadOnly); | ||
| ui->storageStatusLabel->setVisible(m_isStorageReadOnly); | ||
| ui->storageStatusLabel->setText(fi.exists() ? | ||
| QStringLiteral("<b>Docset storage is read only.</b>") : |
There was a problem hiding this comment.
FYI, user visible strings should be wrapped into tr(), so they would be translatable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user modifies the docsets directory from the settings page, the docsets page shows
Docset storage is read-onlywhen the actual source of the error is that the directory does not exist on the file system. This PR fixes that by making the label show the correct error message based on the actual error.