freedesktop zeal.desktop file is broken in the release archive

[craftyguy]

The assets/freedesktop/org.zealdocs.zeal.desktop file has incorrect line endings in the release source archive hosted here on github. The file uses CR in the git repo, but it uses CRLF in the release source archive. Applications on e.g., Linux that follow the fd.o Desktop Entry Spec are unable to use it.

The release tag source archive (e.g. v0.7.0.zip and the git repo have correct line endings for zeal.desktop:

$ file assets/freedesktop/org.zealdocs.zeal.desktop: ASCII text

However the release source archive (e.g. zeal-0.7.0.tar.gz) has incorrect CRLF line endings:

$ file
assets/freedesktop/org.zealdocs.zeal.desktop: ASCII text, with CRLF line terminators

From what I can tell, the release source archives are created in a Windows environment, in the same job that created the Windows builds for your app:

zeal/.github/workflows/release.yaml

Line 87 in db781ed

run: cmake --build build --preset ${{ matrix.config.buildPreset }} --target package_source

and

zeal/.github/workflows/release.yaml

Line 100 in db781ed

build/${{ matrix.config.configurePreset }}/zeal-${{ env.ZEAL_VERSION }}.*

My guess is that the Windows env / build process is enough to change this file's line endings.

As a workaround, Linux distros and others can use the git tag source archives.

[trollixx]

Very odd. That's a static file which is not generated, so Windows or not should not matter. I'll investigate.