Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application quits when there is a new release #637

Closed
atleta opened this issue Oct 18, 2016 · 19 comments
Closed

Application quits when there is a new release #637

atleta opened this issue Oct 18, 2016 · 19 comments
Assignees
Labels
resolution/done Bug fixed, task competed, etc... scope/ui type/defect
Milestone

Comments

@atleta
Copy link

atleta commented Oct 18, 2016

Hi,

I'm running version 0.2.1-2ppa1~wily1 and it stopped working. After launching it, it tells me that there is a new version and I can chose to open the download page or not. However, the app doesn't start. It doesn't make too much sense, since it's an offline app, not a client to an online service. To make things worse, there isn't an up to date version for ubuntu/debian as of now, so the app became unusable.

The quick fix is to block zeal from accessing the server, e.g. by starting it without a network connection...

@trollixx
Copy link
Member

trollixx commented Oct 18, 2016 via email

@atleta
Copy link
Author

atleta commented Oct 19, 2016

Well, I seem to have forgotten to update the ppa link during the last upgrade, now it's OK, thanks!

(On a side note, disabling the check only works after you can start the app, for which you need to block its network access first. Just in case someone is stuck with the old version.)

@gerhard-tinned
Copy link

I had the same issue. The Linux Mint repository provided Zeal but the update was not jet in it. So Zeal stopped working. That is simply WRONG. It is nice that there is a reminder about the new version but it SHOULD NEVER stop working because of this.

@gerhard-tinned
Copy link

Oh, additional it seems the suggestion is not working either. When Zeal has once detected an update, even disconnecting from the network/internet did not allow me to start Zeal. :(

@trollixx
Copy link
Member

trollixx commented Mar 27, 2017 via email

@trollixx
Copy link
Member

The problem still occurs with v0.4.0.

@skorokithakis
Copy link

skorokithakis commented Sep 21, 2017

A workaround is to set:

check_for_update=false

in ~/.config/Zeal/Zeal.conf.

Then Zeal will launch and work fine.

@trollixx
Copy link
Member

trollixx commented Oct 5, 2017

Freshly installed Ubuntu 16.04, and I still cannot reproduce this. Can anyone procure a stack trace?

@skorokithakis
Copy link

@trollixx A stack trace for what? It doesn't crash, it just gives two options: "Open webpage, yes/no". Yes opens the webpage and quits, no doesn't open the webpage and quits. Both options lead to an unusable program.

@trollixx
Copy link
Member

trollixx commented Oct 5, 2017

Neither option is supposed to exit the app, but rather close the message box (and open browser in case of Yes), so I assume the app crashes instead.

@skorokithakis
Copy link

No, it seems to exit normally, with an exit code of 0 even.

@trollixx
Copy link
Member

trollixx commented Oct 5, 2017

This is even weirder than an unreproducible crash.

@skorokithakis Can you run Zeal in debugger, and see what triggers the exit? Setting a break point somewhere here, and then stepping over should give the idea.

@skorokithakis
Copy link

Unfortunately I don't have a C++ toolchain installed :/ Are you getting the dialog box too, and it continues for you instead? It's very odd that I'm not seeing a crash, I'm running 0.3.1. Should there maybe be a return somewhere around here?: https://github.com/zealdocs/zeal/blob/release/0.3/src/libs/ui/mainwindow.cpp#L278

@trollixx
Copy link
Member

trollixx commented Oct 5, 2017

Yeah, the app stays open for me. No idea what is causing it to close for everyone experiencing this problem.

@skorokithakis
Copy link

That's very odd. I tried to compile it but didn't get very far. If you want to send me a build that will log things to console, I'd be happy to run it.

@skorokithakis
Copy link

Oh, something interesting happened: I launched Zeal, it popped the window up, I clicked no and it kept working! I think I've discovered the bug, though, because the main window showed up before the popup:

I think there's a race condition where, if Zeal finds an update before it can show the main window, main window loading is blocked and the program just terminates if the user presses a button. If the main window shows before the popup, then it keeps working.

@skorokithakis
Copy link

Ah, no. It turns out the bug only shows up if you have Zeal set up to start minimized to tray. For some weird and random reason, it started non-minimized even though the setting was set, leading me to discover the difference.

@trollixx
Copy link
Member

@skorokithakis thanks for tracking this down. Now I can reproduce the problem, and hopefully provide a fix shortly.

@trollixx trollixx self-assigned this Oct 10, 2017
@trollixx trollixx added this to the 0.5.0 milestone Oct 10, 2017
@trollixx trollixx changed the title Stops working when there is a new release Application quits when there is a new release Oct 25, 2017
@trollixx trollixx added the resolution/done Bug fixed, task competed, etc... label Oct 25, 2017
@lock
Copy link

lock bot commented Sep 16, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Sep 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
resolution/done Bug fixed, task competed, etc... scope/ui type/defect
Development

No branches or pull requests

4 participants