Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve healthcheck adding restart logic inside for wda #57

Closed
vdelendik opened this issue Feb 23, 2022 · 6 comments
Closed

improve healthcheck adding restart logic inside for wda #57

vdelendik opened this issue Feb 23, 2022 · 6 comments
Labels
enhancement New feature or request
Projects
Device Farm (MCloud)
Milestone
1.4.1

Comments

@vdelendik
Copy link
Contributor

instead of killing node/appium/wda and exit we can try to restart wda
@vdelendik vdelendik added the enhancement New feature or request label Feb 23, 2022
@vdelendik vdelendik added this to the 1.2 milestone Feb 23, 2022
@vdelendik vdelendik added this to To do in Device Farm (MCloud) via automation Feb 23, 2022
vdelendik pushed a commit that referenced this issue Feb 23, 2022
#57: added wda restart as part of helthcheck
4c749cd
vdelendik pushed a commit that referenced this issue Feb 24, 2022
#57: fixed mistake in healthcheck making wda verification a must again
b61b899
vdelendik pushed a commit that referenced this issue Feb 25, 2022
#57: added kill for existing wda during healthcheck
fa1083a
@vdelendik
Copy link
Contributor Author

added also wda kill. let's experiment to see if --session-override should be provided as well... it was discovered that single request with multiply wda tries to start app also several times

vdelendik pushed a commit that referenced this issue Mar 3, 2022
#57: improved wda restart on failure
f2e547a
vdelendik pushed a commit that referenced this issue Mar 3, 2022
#57: added wda startup in healthcheck in case of any problems
d045f53
vdelendik added a commit that referenced this issue Mar 3, 2022
@vdelendik
Merge pull request #64 from zebrunner/#57
9619581 
#57: wda restart during healthcheck
@vdelendik
Copy link
Contributor Author

done: https://github.com/zebrunner/appium/pull/64/files
to verify we can do manual ios kill $WDA_BUNDLEID --udid=$DEVICE_UDID and analyze healthcheck logs
-> in ~30 seconds after kill new WDA session should be started. to see healthcheck logs use:

docker inspect --format "{{json .State.Health }}" device-iPhone_XR-<udid>-appium | jq

Device Farm (MCloud) automation moved this from To do to Ready For QA Mar 3, 2022
@vdelendik vdelendik mentioned this issue Mar 3, 2022
Closed
@dhreben
Copy link
Contributor

dhreben commented Mar 17, 2022

Verified.

Screenshot 2022-03-17 at 14 35 58

@dhreben dhreben moved this from Ready For QA to Done in Device Farm (MCloud) Mar 17, 2022
@vdelendik
Copy link
Contributor Author

reopened as in 1.4 we decided to remove wda restart from healthcheck. if we can proceed without wda restart we can cancel #65

@vdelendik vdelendik reopened this Apr 21, 2022
@vdelendik vdelendik modified the milestones: 1.2, 1.5 Apr 21, 2022
@vdelendik vdelendik moved this from Done to To do in Device Farm (MCloud) Apr 21, 2022
@vdelendik vdelendik modified the milestones: 1.5, 1.4.1 Apr 29, 2022
vdelendik pushed a commit that referenced this issue Apr 29, 2022
#57: restored wda restart by healthcheka
bf794ec
@vdelendik
Copy link
Contributor Author

restored again wda restart on healthcheck reusing separated /opt/start-wda.sh script

Device Farm (MCloud) automation moved this from To do to Ready For QA Apr 29, 2022
@vdelendik vdelendik moved this from Ready For QA to Done in Device Farm (MCloud) Apr 29, 2022
@vdelendik
Copy link
Contributor Author

verified successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Device Farm (MCloud)
Done
Milestone
1.4.1
Development

No branches or pull requests
2 participants
@vdelendik @dhreben