Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag'n'drop file to Zed window #6069

Closed
1 task done
krstp opened this issue Mar 29, 2023 · 6 comments
Closed
1 task done

Drag'n'drop file to Zed window #6069

krstp opened this issue Mar 29, 2023 · 6 comments
Labels
enhancement [core label] workspace Feedback for workspace management, layout, interactions, etc

Comments

@krstp
Copy link

krstp commented Mar 29, 2023

Check for existing issues

  • Completed

Describe the feature

As in the topic, this is request for a drag'n'drop files into Zed window. Currently I can drop the file on the app icon, which will open the file, but dropping on-top of the Zed window does nothing. Also drop in particular tab should also allow for a file open in this particular tab.

Thanks for great product and all the team hard work!

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@krstp krstp added enhancement [core label] triage Maintainer needs to classify the issue labels Mar 29, 2023
@krstp
Copy link
Author

krstp commented Mar 29, 2023

As of today, version 0.79.1 the drag'n'drop to icon stopped working the way it was working, now opening file in stand-alone window instead of existing tab. Just providing this input for more insight.

@JosephTLyons JosephTLyons added workspace Feedback for workspace management, layout, interactions, etc and removed triage Maintainer needs to classify the issue labels Mar 30, 2023
@JosephTLyons JosephTLyons mentioned this issue Sep 8, 2023
1 task
@kwando
Copy link

kwando commented Nov 2, 2023

Observed some of my colleagues struggle with this yesterday. I have mostly worked around it myself though :)

They tried to move a file from a Finder window into a project folder, which works in their usual editor of choice vs *ode.

@JosephTLyons
Copy link
Contributor

Just to bring others up to speed - we have a working prototype of this in our codebase, but its not fully complete and we will need to finish off our port to GPUI2 and moving to open source before we fully implement it. That being said, its something we should be able to land, relatively easily, after those blockers are out of the way.

SomeoneToIgnore referenced this issue Jan 7, 2024
Deals with https://github.com/zed-industries/community/issues/1317
Deals with https://github.com/zed-industries/community/issues/486

Reworks pane drag and drop code to support 
* dropping external files into main pane (supports splits same as tabs
and project entries drop) — this will open the file dropped
* dropping external files, tabs and project entries drop into the
terminal — this will add file abs path into the terminal

Release Notes:

- Added a way to drag and drop external files into Zed main & terminal
panes; support tabs and project entries drop into terminal pane
@JosephTLyons
Copy link
Contributor

This is implemented in v0.119.4 preview.

@krstp
Copy link
Author

krstp commented Jan 9, 2024

Thank you much, it is a work facilitator indeed. One more note though at it seems closely related, I cannot find the ticket now, except #5008, which mentions in the comments drag and dropping panes between separate windows, which seems natural extension of current drag’n’drop. This extension would be really helpful.

@danielneubert
Copy link

Hi there, have a very similar bug that may be tied to this one.

Opening a file with Zed always creates a new window. This is also the case for the v0.119.4 preview.

Example use case for me is editing some config files via Finder or Transmit (FTP client) via "Open with" results always in an new window. I'd rather have a new tab attaching to the existing window.

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

4 participants