Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small visual bug(?) with search pane tooltip when empty #4749

Closed
1 task done
Daeraxa opened this issue May 12, 2023 · 2 comments
Closed
1 task done

Small visual bug(?) with search pane tooltip when empty #4749

Daeraxa opened this issue May 12, 2023 · 2 comments
Labels
defect [core label] search / project search Feedback for in-file search, multi-buffer global search, etc

Comments

@Daeraxa
Copy link

Daeraxa commented May 12, 2023

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I guess it's less of a bug and more something which seems undesirable.

  • Open new search pane (cmd + shift + F)
  • Mouseover the tab
  • Weird little empty tooltip shows up

image

Works as expected when actually entering a term

Environment

Zed: v0.86.1 (preview)
OS: macOS 11.5.2
Memory: 8 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Ideally when there is no search term there should either be a placeholder tooltip (e.g. search) or no tooltip at all.

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response
@Daeraxa Daeraxa added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels May 12, 2023
@JosephTLyons JosephTLyons added search / project search Feedback for in-file search, multi-buffer global search, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 15, 2023
@osiewicz osiewicz mentioned this issue Jun 1, 2023
Merged
osiewicz referenced this issue Jun 2, 2023
@osiewicz
Z-1074/search default label (#2547)
571d2f4 
This commit adds a default "Project search" tooltip for empty search
panes. Fixes Linear ticket Z-1074
Release Notes:

- Added default tooltip to empty search panes.
([#1533](https://github.com/zed-industries/community/issues/1533)).
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@jadijadi
Copy link
Contributor

jadijadi commented Mar 8, 2024

I think this can be closed. One less open issue :)

@Moshyfawn
Copy link
Contributor

It seems to be displaying the tab title now, so I'm going to close this issue as suggested.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] search / project search Feedback for in-file search, multi-buffer global search, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jadijadi @Moshyfawn @JosephTLyons @Daeraxa