Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim mapping jj exit normal Unable to insert j afterwards #4286

Closed
1 task done
d1y opened this issue Jan 6, 2024 · 2 comments
Closed
1 task done

vim mapping jj exit normal Unable to insert j afterwards #4286

d1y opened this issue Jan 6, 2024 · 2 comments
Labels
defect [core label] vim

Comments

@d1y
Copy link
Contributor

d1y commented Jan 6, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I can't insert the j symbol right now
fff

my keymap.json

  {
    "context": "Editor && vim_mode == insert",
    "bindings": {
      "j j": "vim::NormalBefore"
    }
  }

Environment

Zed: v0.118.1 (Zed)
OS: macOS 14.2.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

@d1y d1y added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jan 6, 2024
@JosephTLyons JosephTLyons added vim and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jan 7, 2024
@d1y
Copy link
Contributor Author

d1y commented Jan 9, 2024

The zed-preview version it work(0.119.4) 👀
vvv

@ConradIrwin ConradIrwin mentioned this issue Jan 22, 2024
Merged
ConradIrwin referenced this issue Jan 22, 2024
Add support for mapping `jk` to escape in vim mode.

This changes the behaviour of the keymatches when there are pending
matches.

Before: Even if there was a pending match, any complete matches would be
triggered and the pending state lost.

After: If there is a pending match, any complete matches are delayed by
1s, or until more keys are typed.

Release Notes:

- Added support for mapping `jk` in vim mode
([#2378](https://github.com/zed-industries/community/issues/2378)),
([#176](https://github.com/zed-industries/community/issues/176))
@JosephTLyons
Copy link
Contributor

This should be shipped in v0.119.16-pre.

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] vim
Projects
None yet
Development

No branches or pull requests

2 participants