Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension for the BQN language #959

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Conversation

DavidZwitser
Copy link
Contributor

BQN, while relatively niche, is an amazing language, and Zed deserves support for it.
I've implemented all the features Zed has currently. The readme describes the decisions.

@maxdeviant maxdeviant changed the title Language extension for the BQN language Add extension for the BQN language Jun 23, 2024
@maxdeviant
Copy link
Member

Thanks @DavidZwitser!

We'll need to change the extension ID in the extension.toml to be all lowercase: https://github.com/DavidZwitser/zed-bqn/blob/f4fd839564e8b0e37fe7bc99280d431e1f075ea2/extension.toml#L1

- id = "BQN"
+ id = "bqn"

@DavidZwitser
Copy link
Contributor Author

@maxdeviant my latest commit has a lowercase ID. Any further action needed?

@maxdeviant
Copy link
Member

@maxdeviant my latest commit has a lowercase ID. Any further action needed?

You need to update the submodule in this PR to contain that new commit.

Copy link

cla-bot bot commented Jun 25, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @DavidZwitser on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@DavidZwitser
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jun 25, 2024
Copy link

cla-bot bot commented Jun 25, 2024

The cla-bot has been summoned, and re-checked this pull request!

@DavidZwitser
Copy link
Contributor Author

@maxdeviant should be fixed now :) (sorry this is my first PR ever)

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxdeviant maxdeviant merged commit 46ccddd into zed-industries:main Jun 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants