Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unclearable error pane #10217

Closed
rgbkrk opened this issue Apr 6, 2024 · 2 comments · Fixed by #10220
Closed

Unclearable error pane #10217

rgbkrk opened this issue Apr 6, 2024 · 2 comments · Fixed by #10220
Labels
defect [core label] diagnostics Feedback for diagnostics, error messages, logs, etc popovers Feedback for tooltips, syntax hints, info popups, etc

Comments

@rgbkrk
Copy link
Member

rgbkrk commented Apr 6, 2024 •
edited

Check for existing issues

This is a duplicate of #10090

Describe the bug / provide steps to reproduce it

If, when using Rust, an error to build a project is big enough then it's too big to clear from view:

image

Environment

Zed: v0.131.0 (Zed Nightly 773a3e8)
OS: macOS 14.4.1
Memory: 128 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

image

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@rgbkrk rgbkrk added defect [core label] triage Maintainer needs to classify the issue admin read Pending admin review labels Apr 6, 2024
@Moshyfawn
Copy link
Contributor

I have a feeling this is the problem @ConradIrwin has in #10190, which had actually been reported in #10090 🤭

@Moshyfawn Moshyfawn added popovers Feedback for tooltips, syntax hints, info popups, etc diagnostics Feedback for diagnostics, error messages, logs, etc and removed triage Maintainer needs to classify the issue labels Apr 6, 2024
ConradIrwin added a commit that referenced this issue Apr 6, 2024
@ConradIrwin
Improve lsp notifications
264c381 
1. They now will not go off-screen
2. You can scroll long messages.
3. Only one notification per language server is shown at a time
4. The title/text are now distinguished visually
5. You can copy the error message to the clipboard

Fixes: #10217
Fixes: #10190
Fixes: #10090
@ConradIrwin ConradIrwin mentioned this issue Apr 6, 2024
Merged
@rgbkrk
Copy link
Member Author

rgbkrk commented Apr 6, 2024

Sure enough, I'll close this one. I didn't search well enough.

@rgbkrk rgbkrk closed this as completed Apr 6, 2024
ConradIrwin added a commit that referenced this issue Apr 6, 2024
@ConradIrwin
Improve lsp notifications (#10220)
0325bda 
1. They now will not go off-screen
2. You can scroll long messages.
3. Only one notification per language server is shown at a time
4. The title/text are now distinguished visually
5. You can copy the error message to the clipboard

Fixes: #10217
Fixes: #10190
Fixes: #10090

Release Notes:

- Fixed language server notifications being too large
([#10090](#10090)).
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] diagnostics Feedback for diagnostics, error messages, logs, etc popovers Feedback for tooltips, syntax hints, info popups, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve lsp notifications zed-industries/zed
3 participants
@rgbkrk @Moshyfawn @JosephTLyons