Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When soft wrapping is enabled, vim moves forward fails #10350

Closed
1 task done
weartist opened this issue Apr 10, 2024 · 3 comments · Fixed by #10464
Closed
1 task done

When soft wrapping is enabled, vim moves forward fails #10350

weartist opened this issue Apr 10, 2024 · 3 comments · Fixed by #10464
Labels
defect [core label] setting Feedback for preferences, configuration, etc vim

Comments

@weartist
Copy link
Contributor

weartist commented Apr 10, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Not sure if it has anything to do with #10159 , In normal mode, moving forward will stop at the beginning of the line, which should be expected, but it will also stop when soft wrapping is enabled, maybe it should be allowed to move forward here?

2024-04-10.12.57.26.mov

Environment

Zed: v0.129.2 (Zed)
OS: macOS 14.3.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@weartist weartist added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Apr 10, 2024
@0x2CA
Copy link

0x2CA commented Apr 10, 2024

hi,This seems to be no problem if there are spaces in front of the lines.

2024-04-10.15.36.11.mov

@JosephTLyons JosephTLyons added vim setting Feedback for preferences, configuration, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Apr 11, 2024
@ConradIrwin
Copy link
Collaborator

I think this is not related to #10159, but probably shares a common cause (the vim code seems to have been written before soft wrapping :D).

Looking at the implementation of Left and Right in vim, you can see that they use display co-ordinates, they should be updated to use buffer coordinates instead.

@weartist
Copy link
Contributor Author

I think this is not related to #10159, but probably shares a common cause (the vim code seems to have been written before soft wrapping :D).

Looking at the implementation of Left and Right in vim, you can see that they use display co-ordinates, they should be updated to use buffer coordinates instead.

I submitted a simple modification to accommodate soft_wrap. The right movement doesn't need to be handled, it can be done very well XD

ConradIrwin pushed a commit that referenced this issue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] setting Feedback for preferences, configuration, etc vim
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants