Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zed crashes upon spawning task from keybinding #10380

Closed
1 task done
baldwindavid opened this issue Apr 10, 2024 · 2 comments · Fixed by #10383
Closed
1 task done

Zed crashes upon spawning task from keybinding #10380

baldwindavid opened this issue Apr 10, 2024 · 2 comments · Fixed by #10383
Labels
defect [core label] panic / crash [core label] tasks

Comments

@baldwindavid
Copy link
Contributor

baldwindavid commented Apr 10, 2024 •
edited

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

I noticed this immediately upon attempting to run a test under cursor with the latest preview. It appears that spawning any task via keybinding results in an immediate crash. Most minimal example task...

{ "label": "Echo", "command": "echo hello" },

Keybinding in normal mode...

"space t": [
  "task::Spawn",
  {
    "task_name": "Echo"
  }
],

The task works when directly spawning via command palette, just not via keymap.

Environment

Zed: v0.131.0 (Zed Preview)
OS: macOS 14.4.1
Memory: 32 GiB
Architecture: aarch64

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@baldwindavid baldwindavid added admin read Pending admin review defect [core label] panic / crash [core label] triage Maintainer needs to classify the issue labels Apr 10, 2024
@SomeoneToIgnore SomeoneToIgnore mentioned this issue Apr 10, 2024
Merged
SomeoneToIgnore added a commit that referenced this issue Apr 10, 2024
@SomeoneToIgnore
Use proper Workspace references when querying for tasks by name (#10383)
fd3ee5a 
Closes #10380

Release Notes:

- Fixed Zed panicking when running tasks via a keybinding
([10380](#10380))
SomeoneToIgnore added a commit that referenced this issue Apr 10, 2024
@SomeoneToIgnore
Use proper Workspace references when querying for tasks by name (#10383)
25b8e46 
Closes #10380

Release Notes:

- Fixed Zed panicking when running tasks via a keybinding
([10380](#10380))
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Apr 10, 2024
@SomeoneToIgnore
Use proper Workspace references when querying for tasks by name (#10383)
d5a667c 
Closes #10380

Release Notes:

- Fixed Zed panicking when running tasks via a keybinding
([10380](#10380))
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Apr 10, 2024
Closed
@SomeoneToIgnore
Copy link
Contributor

Thank you for reporting, a fix (with the test to hopefully prevent it breaking again) is available in Zed Preview 0.131.1

@baldwindavid
Copy link
Contributor Author

Awesome, works great. Thanks, @SomeoneToIgnore !

@JosephTLyons JosephTLyons added tasks and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] panic / crash [core label] tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use proper Workspace references when querying for tasks by name zed-industries/zed
3 participants
@baldwindavid @SomeoneToIgnore @JosephTLyons