Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open previous workspace on resuming application #10812

Closed
1 task done
williamviktorsson opened this issue Apr 20, 2024 · 1 comment
Closed
1 task done

open previous workspace on resuming application #10812

williamviktorsson opened this issue Apr 20, 2024 · 1 comment
Labels
enhancement [core label] serialization Restoration of the editor state after a restart workspace Feedback for workspace management, layout, interactions, etc

Comments

@williamviktorsson
Copy link
Contributor

Check for existing issues

  • Completed

Describe the feature

In the same way one might configure whether the previous workspace should be opened when opening a fresh Zed instance, I propose that the same functionality is added to resuming a running zed instance with no open workspaces.

In this way, a user would be able to close their editor window and later resume faster than if they quit the application and then resumed to their project.

Currently closing all windows then opening zed opens a fresh workspace, whereas quitting Zed then opening Zed allows for the behavior to be configured.

I tried this and will be submitting a PR. See attached video of me closing the editor window and resuming, versus quitting the application and resuming.

If applicable, add mockups / screenshots to help present your vision of the feature

zed_reopen_demo.mov
@williamviktorsson williamviktorsson added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Apr 20, 2024
@Moshyfawn Moshyfawn added workspace Feedback for workspace management, layout, interactions, etc serialization Restoration of the editor state after a restart and removed triage Maintainer needs to classify the issue labels Apr 22, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Apr 22, 2024
ConradIrwin pushed a commit that referenced this issue Apr 29, 2024
Addresses #10812 

Release Notes:

- Launching an empty already-running Zed application now behaves like a
regular startup and respects the user `resume_on_startup` setting.
([#10812](#10812)).

See attached showcase which highlights how the previous project can now
be re-opened through both "quit" and "close window".

This has a noticeable performance benefit on startup/project resume
time.

This should also make the behaviour of closing/opening an application
consistent between macOS/Linux/Windows.


https://github.com/zed-industries/zed/assets/22855292/9c37ba31-ce0a-4c3d-940d-a56e3347e64a
luckydye pushed a commit to luckydye/zed that referenced this issue Apr 30, 2024
Addresses zed-industries#10812 

Release Notes:

- Launching an empty already-running Zed application now behaves like a
regular startup and respects the user `resume_on_startup` setting.
([zed-industries#10812](zed-industries#10812)).

See attached showcase which highlights how the previous project can now
be re-opened through both "quit" and "close window".

This has a noticeable performance benefit on startup/project resume
time.

This should also make the behaviour of closing/opening an application
consistent between macOS/Linux/Windows.


https://github.com/zed-industries/zed/assets/22855292/9c37ba31-ce0a-4c3d-940d-a56e3347e64a
@JosephTLyons
Copy link
Contributor

This is now in 0.134.0-pre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] serialization Restoration of the editor state after a restart workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

3 participants