Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve resize buffer fontSize git inline-blame icon size #11311

Closed
1 task done
d1y opened this issue May 2, 2024 · 1 comment · Fixed by #11788
Closed
1 task done

Improve resize buffer fontSize git inline-blame icon size #11311

d1y opened this issue May 2, 2024 · 1 comment · Fixed by #11788
Labels
enhancement [core label] git blame git Git integration feedback

Comments

@d1y
Copy link
Contributor

d1y commented May 2, 2024

Check for existing issues

  • Completed

Describe the feature

cmd +/-

Normal:

image

Enlarge:

image

Zoom out:

image

/cc @mrnugget

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@d1y d1y added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels May 2, 2024
@d1y
Copy link
Contributor Author

d1y commented May 2, 2024

Just my opinion: I think icons are optional, and I even feel a bit unnecessary(it is noise pollution)

What do you think about this? @iamnbutler I want to hear your thoughts

@JosephTLyons JosephTLyons added git Git integration feedback git blame and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 3, 2024
@github-actions github-actions bot mentioned this issue May 4, 2024
Open
@mrnugget mrnugget mentioned this issue May 14, 2024
Merged
mrnugget added a commit that referenced this issue May 14, 2024
@mrnugget
inline blame: Match icon size to font size in buffer (#11788)
ec65035 
This fixes #11311.


Release Notes:

- Fixed icon in inline git blame entry not changing with the buffer font
size. ([#11311](#11311)).

Before:

![screenshot-2024-05-14-10 48
49@2x](https://github.com/zed-industries/zed/assets/1185253/4a288cae-a52b-4bee-8681-f1d9ba3b57f3)

After:

![screenshot-2024-05-14-10 50
06@2x](https://github.com/zed-industries/zed/assets/1185253/f7a6a608-8ecc-4642-adbd-80858dea75e9)
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this issue May 18, 2024
@mrnugget @osiewicz
inline blame: Match icon size to font size in buffer (zed-industries#…
95dd4cc 
…11788)

This fixes zed-industries#11311.


Release Notes:

- Fixed icon in inline git blame entry not changing with the buffer font
size. ([zed-industries#11311](zed-industries#11311)).

Before:

![screenshot-2024-05-14-10 48
49@2x](https://github.com/zed-industries/zed/assets/1185253/4a288cae-a52b-4bee-8681-f1d9ba3b57f3)

After:

![screenshot-2024-05-14-10 50
06@2x](https://github.com/zed-industries/zed/assets/1185253/f7a6a608-8ecc-4642-adbd-80858dea75e9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement [core label] git blame git Git integration feedback
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

inline blame: Match icon size to font size in buffer zed-industries/zed
2 participants
@JosephTLyons @d1y