-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LSP textDocument/didOpen Message Missing Language ID #11399
Comments
Nice catch, thank you. |
Awesome! Thank you! |
@ejjonny hmm I pulled these changes in and I attempted to use your Swift extension just now but it's still doing the same thing that the broken extension has always done with no sourcekit-lsp support, was this change supposed to allow things to begin working? |
@furby-tm Yeah, the published swift plugin has no language server, just syntax highlighting with tree sitter. As far as my repo - it needed to point to a tree sitter branch with some generated files to install properly. If you pull down the latest commit you (should?) be able to get up and running. It might help to run If you don't see this (after a couple minutes) in your extensions window in Zed, the plugin didn't install successfully. The standard LSP things should work - however the diagnostics message seems to be broken for me. If you do manage to get up and running you should let me know if you see the same deserialization warning I'm seeing. |
Check for existing issues
Describe the bug / provide steps to reproduce it
LSP client message textDocument/didOpen passes an empty string for textDocument.languageId.
This field is apparently necessary for language servers that support multiple languages such as sourcekit.
LSP object for reference
I believe it is crates/project/src/project.rs line ~2383 or line ~3682 defaulting on a None value.
Environment
Zed: v0.133.7 (Zed)
OS: macOS 14.2.1
Memory: 16 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
No response
If applicable, attach your
~/Library/Logs/Zed/Zed.log
file to this issue.No response
The text was updated successfully, but these errors were encountered: