Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lowercased language name as language id fallback #11412

Merged
merged 3 commits into from
May 5, 2024
Merged

Use lowercased language name as language id fallback #11412

merged 3 commits into from
May 5, 2024

Conversation

SomeoneToIgnore
Copy link
Contributor

Closes #11399

Release Notes:

  • Fixed empty language name in textDocument/didOpen LSP requests (11399)

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label May 5, 2024
@SomeoneToIgnore SomeoneToIgnore mentioned this pull request May 5, 2024
Closed
1 task
@SomeoneToIgnore SomeoneToIgnore merged commit 1e84f01 into main May 5, 2024
8 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/language-id branch May 5, 2024 19:27
mrnugget added a commit that referenced this pull request May 13, 2024
@mrnugget
Fix Vue.js language server not starting
ce307c5 
This fixes #10871.

The introduction of #11412 broke Vue.js language support, since it made
Zed rely more heavily on correct language name -> language ID mappings,
which the Vue.js extension didn't have.
@mrnugget mrnugget mentioned this pull request May 13, 2024
Merged
mrnugget added a commit that referenced this pull request May 13, 2024
@mrnugget
vue: Fix Vue.js language server not starting (#11743)
c769d58 
This fixes #10871.

The introduction of #11412 broke Vue.js language support, since it made
Zed rely more heavily on correct language name -> language ID mappings,
which the Vue.js extension didn't have.

Release Notes:

- N/A
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this pull request May 18, 2024
@mrnugget @osiewicz
vue: Fix Vue.js language server not starting (zed-industries#11743)
b476640 
This fixes zed-industries#10871.

The introduction of zed-industries#11412 broke Vue.js language support, since it made
Zed rely more heavily on correct language name -> language ID mappings,
which the Vue.js extension didn't have.

Release Notes:

- N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LSP textDocument/didOpen Message Missing Language ID
1 participant
@SomeoneToIgnore