Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick command change on macos #11608

Closed
1 task done
Angelk90 opened this issue May 9, 2024 · 2 comments · Fixed by #12037
Closed
1 task done

Quick command change on macos #11608

Angelk90 opened this issue May 9, 2024 · 2 comments · Fixed by #12037
Labels
enhancement [core label] good first issue Issue suitable for first-time contributors keymap / key binding Feedback for keyboard shortcuts, key mapping, etc project panel Feedback for files tree view

Comments

@Angelk90
Copy link

Angelk90 commented May 9, 2024

Check for existing issues

  • Completed

Describe the feature

vscode:
Screenshot 2024-05-09 alle 13 20 06

Zed:
Screenshot 2024-05-09 alle 13 20 50

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@Angelk90 Angelk90 added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels May 9, 2024
@JosephTLyons JosephTLyons added project panel Feedback for files tree view keymap / key binding Feedback for keyboard shortcuts, key mapping, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 9, 2024
@JosephTLyons
Copy link
Contributor

It looks like we have 2 bindings registered for this action and Zed is displaying the first one:

"f2": "project_panel::Rename",
"enter": "project_panel::Rename",

Not sure why we have f2 registered - I would just say we should remove it, but maybe there's a reason here I'm not aware of - could be some sort of backward compatibility...

@JosephTLyons JosephTLyons added the good first issue Issue suitable for first-time contributors label May 9, 2024
@github-actions github-actions bot mentioned this issue May 10, 2024
Open
@nipunshukla21 nipunshukla21 mentioned this issue May 19, 2024
Merged
@80avin
Copy link
Contributor

80avin commented May 19, 2024

I just checked on mac os and linux, and looks like F2 is the actual key binding to rename a variable on both.
While to rename a file, mac has Enter while linux has F2 here also.

So, I don't think this issue asks for the right change.

SomeoneToIgnore pushed a commit that referenced this issue May 20, 2024
@nipunshukla21
Remove F2 keybind for Rename on MacOS and Linux (#12037)
4e935f9 
Fix [#11608](#11608)

Release Notes:

- Changed rename keybind from F2 to Enter in right-click context menu
([#11608](#11608)).

![image](https://github.com/zed-industries/zed/assets/30131536/5ebdbb04-ff4e-46ff-80fb-9e95b2b3d285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement [core label] good first issue Issue suitable for first-time contributors keymap / key binding Feedback for keyboard shortcuts, key mapping, etc project panel Feedback for files tree view
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove F2 keybind for Rename on MacOS and Linux nipunshukla21/zed
3 participants
@80avin @JosephTLyons @Angelk90