Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GPUI issue) Zed crashes when encountering a color containing different chars with the same symbol in a theme #12085

Closed
1 task done
a-usr opened this issue May 21, 2024 · 1 comment
Labels
defect [core label] gpui GPUI rendering framework support panic / crash [core label]

Comments

@a-usr
Copy link
Contributor

a-usr commented May 21, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Say you have a color code #fаfаfa and the a's in this color color are for one part the latin character a and for the other the cyrillic character а, which has a different unicode codepoint. If you passed this color code inside of a theme to zed, the function crates/gpui/src/color.rs::[impl TryFrom<&'_ str> for Rgba]::try_from(value: &'_ str) would create a very confusing panic:
byte index 2 is not a char boundary; it is inside 'а' (bytes 1..3) of fаfаfa

Please see this other issue for Reference: #11997

Environment

Platform-independend

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@a-usr a-usr added admin read Pending admin review defect [core label] panic / crash [core label] triage Maintainer needs to classify the issue labels May 21, 2024
bbb651 added a commit to bbb651/zed that referenced this issue May 21, 2024
@JosephTLyons JosephTLyons added gpui GPUI rendering framework support theme Feedback for theme configuration, accessibility, visual issues, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review theme Feedback for theme configuration, accessibility, visual issues, etc labels May 22, 2024
@JosephTLyons
Copy link
Contributor

A fix for this went out today in v0.138.0-pre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] gpui GPUI rendering framework support panic / crash [core label]
Projects
None yet
Development

No branches or pull requests

2 participants