Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No information popover when autocomplete suggestions are showing #12152

Closed
1 task done
effdotsh opened this issue May 22, 2024 · 2 comments · Fixed by #12157
Closed
1 task done

No information popover when autocomplete suggestions are showing #12152

effdotsh opened this issue May 22, 2024 · 2 comments · Fixed by #12157
Labels
autocompletions Feedback for code completions in the editor defect [core label] documentation [core label] language An umbrella label for all programming languages syntax behaviors python Python programming language support

Comments

@effdotsh
Copy link
Contributor

effdotsh commented May 22, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When hovering over a variable/method, a popover showing information about that variable/method normally appears. However, when there is an autocomplete popover, the information popover does not show up.

2024-05-22.16-02-36.mov

Environment

Zed: v0.136.2 (Zed)
OS: macOS 14.5.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@effdotsh effdotsh added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels May 22, 2024
@effdotsh effdotsh changed the title No information popup when autocomplete suggestions are showing No information popover when autocomplete suggestions are showing May 22, 2024
SomeoneToIgnore pushed a commit that referenced this issue May 24, 2024
…2157)

Allows information popovers to display while autocomplete suggestions
are also being displayed.

Before: 


https://github.com/zed-industries/zed/assets/50590465/a61f0b4e-1521-42de-84fd-c5a3586b74ab

After:


https://github.com/zed-industries/zed/assets/50590465/ad2daae7-aebc-4c71-ad4c-f9d2deb6d0d0

Release Notes:
- Allow hover and completion popovers to appear at the same time ([12152](#12152))
@JosephTLyons JosephTLyons added documentation [core label] python Python programming language support language An umbrella label for all programming languages syntax behaviors autocompletions Feedback for code completions in the editor and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 24, 2024
@JosephTLyons
Copy link
Contributor

JosephTLyons commented May 24, 2024

I think I reported this issue before, but we closed it after some investigation from @osiewicz:

Cool to see a fix go out.

@effdotsh
Copy link
Contributor Author

effdotsh commented May 24, 2024

@JosephTLyons I believe these are different issues. This is just not displaying two popovers at once, not the content of the popovers. This also wasn't python specific, here's the issue in rust:

2024-05-24.13-05-46.mov

It does seem like that issue was fixed somewhere though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocompletions Feedback for code completions in the editor defect [core label] documentation [core label] language An umbrella label for all programming languages syntax behaviors python Python programming language support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants