Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resuming previous insert mode (gi) can't continue from the end of the line #12162

Closed
1 task done
silvenon opened this issue May 22, 2024 · 1 comment
Closed
1 task done

Resuming previous insert mode (gi) can't continue from the end of the line #12162

silvenon opened this issue May 22, 2024 · 1 comment
Labels
defect [core label] vim

Comments

@silvenon
Copy link

silvenon commented May 22, 2024 •
edited
Loading

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

The newly added gi seems to work well except in the instance where the insert mode ended at the end of a line — in that case it starts one character earlier. In the video I had to push the cursor to the end of the line with the arrow key so it's looks a little awkward, but the bug remains consistent.

And I checked nvim's behavior, it manages to continue from the end of the line.

Environment

Zed: v0.136.2 (Zed)
OS: macOS 14.5.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screen.Recording.2024-05-22.at.23.55.23.mov

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@silvenon silvenon added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels May 22, 2024
@JosephTLyons JosephTLyons added vim and removed triage Maintainer needs to classify the issue admin read Pending admin review labels May 24, 2024
@github-actions github-actions bot mentioned this issue May 25, 2024
Open
@ConradIrwin ConradIrwin mentioned this issue Jun 14, 2024
Merged
ConradIrwin added a commit that referenced this issue Jun 14, 2024
@ConradIrwin
vim gigv (#13028)
3b84b10 
Release Notes:

- vim: Fix `gi` when the insert ended at the end of a line (#12162)
- vim: Add `gv` to restore previous visual selection (#12888)
- vim: Fix `gl` when the first match is at the end of a line
@ConradIrwin
Copy link
Collaborator

Fixed by #13028

fallenwood pushed a commit to fallenwood/zed that referenced this issue Jun 18, 2024
@ConradIrwin @fallenwood
vim gigv (zed-industries#13028)
52e1373 
Release Notes:

- vim: Fix `gi` when the insert ended at the end of a line (zed-industries#12162)
- vim: Add `gv` to restore previous visual selection (zed-industries#12888)
- vim: Fix `gl` when the first match is at the end of a line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] vim
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ConradIrwin @silvenon @JosephTLyons