Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript shorthand property syntax isn't highlighted in TSX #12510

Closed
1 task done
Moshyfawn opened this issue May 30, 2024 · 1 comment
Closed
1 task done

Typescript shorthand property syntax isn't highlighted in TSX #12510

Moshyfawn opened this issue May 30, 2024 · 1 comment
Labels
defect [core label] language An umbrella label for all programming languages syntax behaviors tsx TypeScript JSX support

Comments

@Moshyfawn
Copy link
Contributor

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

<Title>

Related: #5239

Environment

Zed: v0.139.0 (Zed Nightly fda975f)
OS: macOS 14.5.0
Memory: 18 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

const bool = true;

const obj = { string: "foo", bool } // INFO: `bool` shorthand property isn't highlighted like `string` property (GH highlights it too, super handy 🤭)

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@Moshyfawn Moshyfawn added defect [core label] language An umbrella label for all programming languages syntax behaviors admin read Pending admin review tsx TypeScript JSX support labels May 30, 2024
@Moshyfawn Moshyfawn mentioned this issue May 30, 2024
Closed
1 task
jaydenseric added a commit to jaydenseric/zed that referenced this issue May 31, 2024
@jaydenseric
Fix TSX and JavaScript shorthand property syntax highlighting.
9069d8a 
Fixes zed-industries#12510 and fixes zed-industries#12509 .
@jaydenseric jaydenseric mentioned this issue May 31, 2024
Merged
@JosephTLyons JosephTLyons removed the admin read Pending admin review label May 31, 2024
osiewicz pushed a commit that referenced this issue Jun 2, 2024
@jaydenseric
Fix TSX and JavaScript shorthand property syntax highlighting (#12512)
b218d87 
This replicates the fix for the TypeScript language for
#5239 in
#12505 for the TSX and
JavaScript languages, fixing
#12510 and fixing
#12509 .

See
#12505 (comment)
.

Keep in mind I don't have a proper Zed local development environment
setup to test these simple changes.

Release Notes:

- Fixed TSX shorthand property syntax highlighting
([#12510](#12510)).
- Fixed JavaScript shorthand property syntax highlighting
([#12509](#12509)).
@JosephTLyons
Copy link
Contributor

This just landed in v0.139.0-pre today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] language An umbrella label for all programming languages syntax behaviors tsx TypeScript JSX support
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Moshyfawn @JosephTLyons