Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home and End should not exit visual mode in vim_mode #13068

Closed
1 task done
wizardwatch opened this issue Jun 14, 2024 · 0 comments · Fixed by #13086
Closed
1 task done

Home and End should not exit visual mode in vim_mode #13068

wizardwatch opened this issue Jun 14, 2024 · 0 comments · Fixed by #13086
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc vim

Comments

@wizardwatch
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Using vim_mode, enter visual mode and press either home or end. Both exit visual mode, dropping the selection. In both Vim and Neovim, this is not the case.

Environment

Zed: v1.0.0 (Zed)
OS: Linux 1.0.0
Memory: 31.2 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@wizardwatch wizardwatch added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jun 14, 2024
ConradIrwin added a commit that referenced this issue Jun 15, 2024
@ConradIrwin
vim: Fix minor keybinding bugs
ced3dbe 
Fixes: #13068
Fixes: #9383
@ConradIrwin ConradIrwin mentioned this issue Jun 15, 2024
Merged
ConradIrwin added a commit that referenced this issue Jun 15, 2024
@ConradIrwin
vim: Fix minor keybinding bugs (#13086)
7cc2538 
Fixes: #13068
Fixes: #9383



Release Notes:

- vim: Fixed `home` and `end` in visual mode (#13068)
- vim: Fixed inserting a 0 in insert mode with a count (#9383)
@Moshyfawn Moshyfawn added vim editor Feedback for code editing, formatting, editor iterations, etc and removed triage Maintainer needs to classify the issue labels Jun 15, 2024
@notpeter notpeter removed the admin read Pending admin review label Jun 16, 2024
fallenwood pushed a commit to fallenwood/zed that referenced this issue Jun 18, 2024
@ConradIrwin @fallenwood
vim: Fix minor keybinding bugs (zed-industries#13086)
4f75787 
Fixes: zed-industries#13068
Fixes: zed-industries#9383



Release Notes:

- vim: Fixed `home` and `end` in visual mode (zed-industries#13068)
- vim: Fixed inserting a 0 in insert mode with a count (zed-industries#9383)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc vim
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vim: Fix minor keybinding bugs zed-industries/zed
3 participants
@notpeter @Moshyfawn @wizardwatch