Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support openInIntegratedTerminal or RevealInTerminal command #4566

Closed
1 task done
networkhermit opened this issue Jul 31, 2023 · 0 comments · Fixed by #10741
Closed
1 task done

support openInIntegratedTerminal or RevealInTerminal command #4566

networkhermit opened this issue Jul 31, 2023 · 0 comments · Fixed by #10741
Labels
enhancement [core label] keymap / key binding Feedback for keyboard shortcuts, key mapping, etc terminal Feedback for terminal integration, shell commands, etc

Comments

@networkhermit
Copy link

Check for existing issues

  • Completed

Describe the feature

VSCode has openInIntegratedTerminal command, which is extremely useful for opening the builtin terminal to the path of currently edited file.

I think this feature is even more useful than editor::RevealInFinder for us developers.

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@networkhermit networkhermit added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Jul 31, 2023
@JosephTLyons JosephTLyons added terminal Feedback for terminal integration, shell commands, etc keymap / key binding Feedback for keyboard shortcuts, key mapping, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Aug 3, 2023
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@networkhermit networkhermit mentioned this issue Feb 25, 2024
Closed
1 task
@SomeoneToIgnore SomeoneToIgnore mentioned this issue Apr 18, 2024
Merged
SomeoneToIgnore added a commit that referenced this issue Apr 18, 2024
@SomeoneToIgnore
Add "Open in Terminal" context menu entries for project panel, editor…
870a61d 
… and tab context menus (#10741)

Closes #4566

Pane tabs (does not exist for multibuffer tabs):
<img width="439" alt="Screenshot 2024-04-18 at 23 01 08"
src="https://github.com/zed-industries/zed/assets/2690773/3af79ed8-07ea-4cf2-bcf9-735b1b3be8c4">

Editor context menu:
<img width="404" alt="Screenshot 2024-04-18 at 23 01 14"
src="https://github.com/zed-industries/zed/assets/2690773/38ea7afc-df2b-45ef-8331-eb6a4588af9f">

Project panel context menu (was not shown for file entries before this):
<img width="408" alt="Screenshot 2024-04-18 at 23 01 18"
src="https://github.com/zed-industries/zed/assets/2690773/e336fce1-7da0-4671-b8d2-8d3409c23eb6">

Release Notes:

- (breaking change) Moved `project_panel::OpenInTerminal` into
`workspace::OpenInTerminal` action and add it in editors, tab context
menus and proper panel file entries
([4566](#4566))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement [core label] keymap / key binding Feedback for keyboard shortcuts, key mapping, etc terminal Feedback for terminal integration, shell commands, etc
Projects
None yet
Milestone
No milestone
2 participants
@networkhermit @JosephTLyons