Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline diagnostic messages are still visible after folding surrounding code #4659

Closed
1 task done
izuzak opened this issue Jun 25, 2023 · 0 comments · Fixed by #11167
Closed
1 task done

Inline diagnostic messages are still visible after folding surrounding code #4659

izuzak opened this issue Jun 25, 2023 · 0 comments · Fixed by #11167
Labels
defect [core label] diagnostics Feedback for diagnostics, error messages, logs, etc editor Feedback for code editing, formatting, editor iterations, etc

Comments

@izuzak
Copy link
Contributor

izuzak commented Jun 25, 2023

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Inline diagnostic messages are still visible after folding surrounding code, making the result look weird/wrong.

Instead, if the line of code that the diagnostic message is associated with is not visible due to folding, the diagnostic message should not be visible either.

Environment

Zed: v0.91.3 (stable)
OS: macOS 13.4.0
Memory: 64 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

zed

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response
@izuzak izuzak added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jun 25, 2023
@JosephTLyons JosephTLyons added editor Feedback for code editing, formatting, editor iterations, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jun 26, 2023
@JosephTLyons JosephTLyons mentioned this issue Jan 24, 2024
Open
@JosephTLyons JosephTLyons added the diagnostics Feedback for diagnostics, error messages, logs, etc label Oct 10, 2023
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
osiewicz added a commit that referenced this issue Apr 29, 2024
@osiewicz
editor: Clear diagnostics when folding a range that contains it.
bcb5807 
Fixes #4659
@osiewicz osiewicz mentioned this issue Apr 29, 2024
Merged
osiewicz added a commit that referenced this issue Apr 29, 2024
@osiewicz
editor: Clear diagnostics when folding a range that contains it (#11167)
91b3c24 
Fixes #4659 

Release Notes:

- Fixed active diagnostic in editor showing up when it's line is in a
folded range.
luckydye pushed a commit to luckydye/zed that referenced this issue Apr 30, 2024
@osiewicz @luckydye
editor: Clear diagnostics when folding a range that contains it (zed-…
7cf3dbc 
…industries#11167)

Fixes zed-industries#4659 

Release Notes:

- Fixed active diagnostic in editor showing up when it's line is in a
folded range.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] diagnostics Feedback for diagnostics, error messages, logs, etc editor Feedback for code editing, formatting, editor iterations, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

editor: Clear diagnostics when folding a range that contains it zed-industries/zed
2 participants
@izuzak @JosephTLyons