Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recently open files palette #4663

Open
1 task done
rtorr opened this issue Jun 22, 2023 · 8 comments
Open
1 task done

Recently open files palette #4663

rtorr opened this issue Jun 22, 2023 · 8 comments
Labels
enhancement [core label] file finder Feedback for file management, navigation, etc

Comments

@rtorr
Copy link

rtorr commented Jun 22, 2023

Check for existing issues

  • Completed

Describe the feature

In other editors (vscode/intellij), they provide a palette with recently open files. You can either fuzzy search or go through the list manually with arrow keys (I usually set a different keybinding for selecting which file). When you arrow down, as the selection changes, the editor will update with that selected file. Hitting enter will dismiss the palette.

I do this because I like to hide editor tabs (another feature request for another time?) and only select recently opened files through this pane.

To demo this flow in vscode, these are the keybindings I use and the commands.

  {
    "key": "cmd+e",
    "command": "workbench.action.openPreviousEditorFromHistory"
  },
  {
    "key": "cmd+e",
    "command": "workbench.action.quickOpenNavigateNext",
    "when": "inQuickOpen"
  },

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@rtorr rtorr added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Jun 22, 2023
@iamnbutler
Copy link
Member

Have you used cmd + p before? Similar to the command palette, it lists recently open files, and you can search for files across your project.

You can also use cmd + option + o to do the same for recently opened projects. There is also an upcoming palette to do the same with git branches.

Is there some value to you specifically to match only recently opened files in the fuzzy search in the cmd + p palette?

@JosephTLyons JosephTLyons added file finder Feedback for file management, navigation, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jun 26, 2023
@JosephTLyons
Copy link
Contributor

I think what we are missing here for you is the ability to live load the file, while traversing the list of previously-opened files, and the abillity to customize the the bindings for navigating those files. Does that seem correct?

@tychedelia
Copy link
Contributor

tychedelia commented Jul 12, 2023

Is there some value to you specifically to match only recently opened files in the fuzzy search in the cmd + p palette?

One simple issue I have with the cmd + p action right now is that it always lists the currently open file at the top. Instead, it should show the most recent file, which would allow you to bounce between the two most recently opened files by repeating cmd + p. This is an interaction I use all the time and feels really painful being missing.

More generally, I think this represents a different kind of editing style that eschews tabs for the concepts of "buffers" or recent locations (see IntelliJ). Basically, I don't want to operate on "open files" or see tabs at all in UI (see also #4963). Ideally it should also be possible to "remove" recent files (the equivalent of closing the tab).

An example of my workspace from IntelliJ of "recent locations" which is even better than recent files:
image

@tychedelia
Copy link
Contributor

Another example of where project files falls short is pseudo-files or buffers like the center terminal tab(s), which should be searchable so you don't have to click to navigate.

@tychedelia
Copy link
Contributor

The tabs issue is currently being tracked here #4963. I agree that these are very closely linked and roll up into a bigger "tabless editing" feature, although I'm not sure if that would be helpful to track on its own.

@tychedelia
Copy link
Contributor

Okay, actually the behavior in IntelliJ is a little more subtle. It's not that the currently opened file is ignored in the recent files, it's that it automatically selects the second entry in the list, allowing you to quickly switch back and forth.
image

@rtorr
Copy link
Author

rtorr commented Sep 14, 2023

Yes, exactly. It is all about the shortcuts as well.

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
SomeoneToIgnore pushed a commit that referenced this issue Feb 1, 2024
This PR completes the first task of the Tabless editing feature (#6424).
It makes file finder select the previously opened file by default which
allows the user to quickly switch between two last opened files by
clicking `Cmd-P + Enter`.

This feature was also requested in #4663 comments.

Release Notes:
* Improved file finder selection: currently opened item is not selected now
@gatspy
Copy link

gatspy commented Jul 5, 2024

I hope that folders and files can be dragged into panel like the sublime, and the next startup still keep them intact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] file finder Feedback for file management, navigation, etc
Projects
None yet
Development

No branches or pull requests

5 participants