Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-signed back into my GitHub account after sign out #4716

Closed
1 task done
Moshyfawn opened this issue Jun 1, 2023 · 2 comments
Closed
1 task done

Auto-signed back into my GitHub account after sign out #4716

Moshyfawn opened this issue Jun 1, 2023 · 2 comments
Labels
collaboration The umbrella label for all collaboration features defect [core label]

Comments

@Moshyfawn
Copy link
Contributor

Moshyfawn commented Jun 1, 2023 •
edited

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Description

After signing out of my GitHub/Zed account and reopening Zed, I am automatically logged back in.

Expected behaviour:

I would expect Zed to launch without automatically signing me back into my GitHub/Zed account.

Reproduction steps:

  1. Open Zed.
  2. Make sure you are logged into your GitHub/Zed account.
  3. Click on your profile picture.
  4. Select the "Sign Out" button.
  5. Close Zed.
  6. Re-open Zed.
  7. See you are not automatically logged back into your GitHub/Zed account (you should see your profile picture).

Note

Might be related to #4908. Altho, in my case, I'm explicitly signing out of my account

Environment

Zed: v0.88.5 (stable)
OS: macOS 13.3.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

zed-auto-sign-in.mp4

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response
@Moshyfawn Moshyfawn added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jun 1, 2023
@senev3141
Copy link

senev3141 commented Jun 3, 2023 •
edited

This is a known issue #5633, at the time being you can remove Zed from your keychains which will prompt you to login with a new github account (#5633).

Edit: you can find more details about it here as well #4724

@JosephTLyons JosephTLyons added collaboration The umbrella label for all collaboration features and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jun 5, 2023
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@SomeoneToIgnore SomeoneToIgnore mentioned this issue Feb 22, 2024
Closed
1 task
@pedrosoares pedrosoares mentioned this issue Apr 15, 2024
Merged
ConradIrwin added a commit that referenced this issue Apr 17, 2024
@pedrosoares @ConradIrwin
Clear credentials state and delete keychain on SignOut request (#10558)
c81eb41 
Release Notes:

- Fixed ([#4716](#4716)).

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
@JosephTLyons
Copy link
Contributor

This landed in Zed v0.132.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
collaboration The umbrella label for all collaboration features defect [core label]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Moshyfawn @JosephTLyons @senev3141