Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to show errors inline like VS Code(error lens) #4901

Open
1 task done
victororlyk opened this issue Mar 19, 2023 · 8 comments
Open
1 task done

add ability to show errors inline like VS Code(error lens) #4901

victororlyk opened this issue Mar 19, 2023 · 8 comments
Labels
diagnostics Feedback for diagnostics, error messages, logs, etc editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label]

Comments

@victororlyk
Copy link

Check for existing issues

  • Completed

Describe the feature

It would be really nice to have ability to see the error inline without need to hover or go with cursor to that place.
I really love this extension, but I think it would be nice to have in the code of editor

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@victororlyk victororlyk added enhancement [core label] triage Maintainer needs to classify the issue labels Mar 19, 2023
@victororlyk victororlyk mentioned this issue Mar 19, 2023
Closed
@fdionisi
Copy link
Contributor

@victororlyk is not precisely the same as the error lens plugin, but have you already tried pressing f8 (and/or shift+f8)? It brings you to the next diagnostic and inlines the error.

@victororlyk
Copy link
Author

victororlyk commented Mar 19, 2023 •
edited

@fdionisi yeah i have, those are cool, but I don't use f keys a lot. I have keyboard with f row and it is a bit annoying to use fs i use them only when it is really needed) https://happyhackingkb.com/. So a for me i just use vim keybinding to jump to the error for me it is faster) vim remappings would help ))

@JosephTLyons JosephTLyons added editor Feedback for code editing, formatting, editor iterations, etc and removed triage Maintainer needs to classify the issue labels Mar 19, 2023
@diocletiann
Copy link

Agree. This is key feature still keeping me on JetBrains (with Inspection Lens plugin).

@probablykasper
Copy link

For context, error lens looks like this, with red/orange line and text:
image

@JosephTLyons JosephTLyons added the diagnostics Feedback for diagnostics, error messages, logs, etc label Oct 10, 2023
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@Moshyfawn Moshyfawn mentioned this issue Feb 28, 2024
Closed
1 task
@dumski
Copy link

dumski commented Mar 25, 2024

Hi, any updates on this?

@barel-mishal
Copy link

any update also here?

@freidev
Copy link

freidev commented Apr 18, 2024

Hello, thank you for all the great work you have done, it is a great editor, I just need this functionality to move from vscode to zed. 🚀

This was referenced Apr 28, 2024
Merged
Closed
@Moshyfawn Moshyfawn mentioned this issue May 8, 2024
Open
1 task
osiewicz pushed a commit that referenced this issue May 10, 2024
@kahlstrm
editor: Support walking through overlapping diagnostics (#11139)
b8a8344 
While looking into how to implement #4901, noticed that the current
`Goto next/previous diagnostic` behaved a bit weirdly. That is, when
there are multiple errors that have overlapping ranges, only the first
one can be chosen to be active by the `go_to_diagnostic_impl`.

### Previous behavior:


https://github.com/zed-industries/zed/assets/71292737/95897675-f5ee-40e5-869f-0a40066eb8e3

Doesn't go through all the diagnostics, and going backwards and forwards
doesn't show the same diagnostic always.

### New behavior:


https://github.com/zed-industries/zed/assets/71292737/81f7945a-7ad8-4a34-b286-cc2799b10500

Should always go through the diagnostics in a consistent manner.

Release Notes:
* Improved the behavioral consistency of "Go to Next/Previous
Diagnostic"
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this issue May 18, 2024
@kahlstrm @osiewicz
editor: Support walking through overlapping diagnostics (zed-industri…
70e24cf 
…es#11139)

While looking into how to implement zed-industries#4901, noticed that the current
`Goto next/previous diagnostic` behaved a bit weirdly. That is, when
there are multiple errors that have overlapping ranges, only the first
one can be chosen to be active by the `go_to_diagnostic_impl`.

### Previous behavior:


https://github.com/zed-industries/zed/assets/71292737/95897675-f5ee-40e5-869f-0a40066eb8e3

Doesn't go through all the diagnostics, and going backwards and forwards
doesn't show the same diagnostic always.

### New behavior:


https://github.com/zed-industries/zed/assets/71292737/81f7945a-7ad8-4a34-b286-cc2799b10500

Should always go through the diagnostics in a consistent manner.

Release Notes:
* Improved the behavioral consistency of "Go to Next/Previous
Diagnostic"
@baronetto
Copy link

Any updates on this? This is really keeping from switching to Zed.

@github-actions github-actions bot mentioned this issue May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
diagnostics Feedback for diagnostics, error messages, logs, etc editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@dumski @baronetto @fdionisi @probablykasper @diocletiann @JosephTLyons @victororlyk @freidev @barel-mishal