Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erlang support #4939

Closed
1 task done
eproxus opened this issue Mar 15, 2023 · 5 comments · Fixed by #7093
Closed
1 task done

Erlang support #4939

eproxus opened this issue Mar 15, 2023 · 5 comments · Fixed by #7093
Labels
enhancement [core label] language An umbrella label for all programming languages syntax behaviors potential extension Functionality that could be implemented as an extension (consider moving to community extensions) unsupported language

Comments

@eproxus
Copy link

eproxus commented Mar 15, 2023

Check for existing issues

  • Completed

Language

Erlang

Tree Sitter parser link

https://github.com/WhatsApp/tree-sitter-erlang

Language server link

https://github.com/erlang-ls/erlang_ls

Misc notes

No response
@eproxus eproxus added enhancement [core label] language An umbrella label for all programming languages syntax behaviors triage Maintainer needs to classify the issue labels Mar 15, 2023
@JosephTLyons JosephTLyons removed the triage Maintainer needs to classify the issue label Mar 16, 2023
@JosephTLyons JosephTLyons changed the title Erlang Language Support Erlang support Apr 6, 2023
@hovsater hovsater added the potential extension Functionality that could be implemented as an extension (consider moving to community extensions) label Apr 30, 2023
@hovsater
Copy link
Contributor

hovsater commented May 22, 2023 •
edited

Please refrain from adding comments such as +1 or bump to these issues. We're aware that there's an interest in Erlang support (as well as other languages) and bumping this issue won't make us work faster. The best way to show interest in this feature is by reacting with a 👍 on the original issue.

Whenever there's news to share, I'll make sure to let you all know. 🙂

@samgaw
Copy link

samgaw commented Dec 29, 2023

There's also whatsapp/erlang-language-platform that might make it easier to integrate into testing.

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
wingyplus added a commit to wingyplus/zed that referenced this issue Jan 30, 2024
@wingyplus
Make Erlang syntax highlight works
55a5329 
Updates zed-industries#4939

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
@wingyplus
Copy link
Contributor

👋 Start working on Erlang support. 😄

Screenshot 2567-01-30 at 15 26 38

@wingyplus wingyplus mentioned this issue Jan 30, 2024
Closed
@codeadict
Copy link
Contributor

Lol i started tok @wingyplus , and added erlang_ls as well. I can review your PR

@codeadict codeadict mentioned this issue Jan 30, 2024
Merged
@codeadict
Copy link
Contributor

codeadict commented Jan 30, 2024 •
edited

Added an alternative PR #7093, @wingyplus I'm happy to keep yours and if we can incorporate my changes that would be great too

SomeoneToIgnore pushed a commit that referenced this issue Feb 1, 2024
@codeadict @wingyplus
Add syntax highlighting and LSP (erlang_lsp) for Erlang (#7093)
97be0a9 
This pull request implements support for the [Erlang
Language](https://erlang.org/).

**It adds:**

* [tree-sitter-erlang](https://github.com/WhatsApp/tree-sitter-erlang)
grammar
highlights (Licensed under Apache-2 from WhatsApp which is compatible
with Zed licensing model), folds and indents
* Erlang file icon based on the [official
one](https://www.erlang.org/doc/erlang-logo.png)
* [erlang_ls](https://github.com/erlang-ls/erlang_ls) support

Fixes #4939, possibly a
duplicate of #7085 with more
features. Suppose @wingyplus wants to join efforts here.

**To complete (out of scope for this PR):**

* Support for the ELP language server from WhatsApp. CC @robertoaloi
* Better indentation handling, need something like
`indentNextLinePattern` in VS Code

**Screenshots:**

![Screenshot 2024-01-30 at 11 03 51
AM](https://github.com/zed-industries/zed/assets/168440/5289c245-9edd-46b8-b443-d7b3210f6510)
![Screenshot 2024-01-30 at 11 01 19
AM](https://github.com/zed-industries/zed/assets/168440/bd22b322-5344-44e6-b5f7-6e352fb3deef)
![Screenshot 2024-01-30 at 11 01 37
AM](https://github.com/zed-industries/zed/assets/168440/f28f6a15-383e-4719-8a87-fceae5062436)
![Screenshot 2024-01-30 at 11 02 03
AM](https://github.com/zed-industries/zed/assets/168440/980d5213-0367-4a08-86eb-5743dfa628eb)
![Screenshot 2024-01-30 at 11 02 19
AM](https://github.com/zed-industries/zed/assets/168440/ea998891-604d-48d6-929f-ae4c1bb3fae1)

Outline: 
![Screenshot 2024-01-31 at 9 09 36
AM](https://github.com/zed-industries/zed/assets/168440/46d56d94-21c3-414d-84fb-9251fa2506ab)



**Release Notes:**

* Added Erlang Support
([7093](#7093)).

---------

Signed-off-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Co-authored-by: Thanabodee Charoenpiriyakij <wingyminus@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement [core label] language An umbrella label for all programming languages syntax behaviors potential extension Functionality that could be implemented as an extension (consider moving to community extensions) unsupported language
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add syntax highlighting and LSP (erlang_lsp) for Erlang codeadict/zed
6 participants
@samgaw @eproxus @codeadict @wingyplus @hovsater @JosephTLyons