Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move files to system trash when deleting a file within Zed #5094

Closed
1 task done
JosephTLyons opened this issue Dec 4, 2022 · 4 comments · Fixed by #10875
Closed
1 task done

Move files to system trash when deleting a file within Zed #5094

JosephTLyons opened this issue Dec 4, 2022 · 4 comments · Fixed by #10875
Labels
enhancement [core label] project panel Feedback for files tree view setting Feedback for preferences, configuration, etc

Comments

@JosephTLyons
Copy link
Contributor

JosephTLyons commented Dec 4, 2022

Check for existing issues

  • Completed

Is your feature request related to a problem?

A user had a great suggestion of not hard deleting files when they are deleted within Zed, but instead moving them into the system trash bin. Despite us not really hearing this feedback a lot, I think it's important to reduce the chances of destroying a user's work (for example, if a file isn't tracked by Git).

It probably makes sense for us to add a setting for this, since some users do seem to like the idea of hard deleting. VS Code has a setting for this:

SCR-20221204-j5x-2

Describe the solution you'd like

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@JosephTLyons JosephTLyons added enhancement [core label] project panel Feedback for files tree view setting Feedback for preferences, configuration, etc labels Dec 4, 2022
@jbergstroem
Copy link

Nova.app does the same

@JosephTLyons
Copy link
Contributor Author

Seems like Sublime Text does as well.

@Pringlers
Copy link

IntelliJ-based IDEs remove files directly (I don’t like their behavior tho)

@cgiacomi-work
Copy link

Just deleted a file by mistake and lost 2 hours of work because I had not committed my changes, if the file had been send to the trash can I could have recovered my work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement [core label] project panel Feedback for files tree view setting Feedback for preferences, configuration, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants