CMD + Delete in the File Tree

[shellscape]

Check for existing issues

• Completed

Describe the feature

Within Atom and VS Code, it's possible to delete files without being prompted by using the CMD + Delete key combination. Emphasis on without being prompted. This is a pretty clutch feature that's key to productivity and speed of use within the editor.

If applicable, add mockups / screenshots to help present your vision of the feature

FWIW in VS Code this sends something to the trash. A key combo which hard deletes, like rm -rf does`, without recovery would also be useful. It's usually 50/50 when I want to delete something to get it out of the way with the chance of needing it later, or wanting to nuke it from orbit.

The current delete on the file tree items does not send items to trash. Something that could probably use some discussion.

[shellscape]

@huacnlee @JosephTLyons I'm not sure if there's a regression in 0.125.0 or if the PR to resolve this misunderstood the issue.

Currently in v0.125.0 when I hit backspace/delete on a file in the tree, it does nothing where it used to prompt for delete. I now have to use CMD+delete. That's not ideal behavior.

The original intent was to match VSCode where:

• using just the delete key will prompt for a delete with "Are you sure?"
• using CMD+delete key will delete without a prompt

In both cases, the files should go to the Trash

[shellscape]

@SomeoneToIgnore tagging you here since you merged, and this is possibly a regression.

[JosephTLyons]

@shellscape - I'll let Kirill respond about the changes to the deletion in the file tree. As for sending files to the trash can, I think we should probably be doing that:

• Move files to system trash when deleting a file within Zed #5094

[huacnlee]

Actually I was do that PR was want remove confirm dialog when we triggered CMD-Backspace.

But then I reverted that to keep it. Because I don't sure that why Zed team make like that. So I just let Delete and CMD-Backspace can work. Keep the confirm dialog.

[shellscape]

I see. On my end, using just delete no longer does anything.

[SomeoneToIgnore]

Here's a video that I've recorded on the fresh Zed version with both bindings.

Screen.Recording.2024-02-29.at.21.31.33.mov

In the bottom left corner of the video, keybindings are shown:

• backspace: ⌫
• delete: ⌦
• cmd: ⌘
• escape: ⎋

Current settings state this

"delete": "project_panel::Delete",
"cmd-backspace": "project_panel::Delete",

and first, the video ensures that simple backspace does not trigger the deletion modal, then ensures that both cmd-backspace and delete work.

Then the video disables the binding for delete and tries the same: now to show, that both backspace and delete do not cause the modal to appear, only cmd-backspace does.

---

I see. On my end, using just delete no longer does anything.

So, both delete and cmd-backspace work.
Can you check your keybindings and ensure it's not the plain backspace that does nothing?

The PRs intent was to restore the missing (at that moment) delete binding, but apparently both the PR creator and myself were reading through this issue badly and did notice the dialogue-less emphasis, so let's reopen the issue for now.

[SomeoneToIgnore]

This looks simple to fix:

Project panel responds to deletion action and opens the prompt here:

zed/crates/project_panel/src/project_panel.rs

Lines 797 to 802 in dab886f

	let answer = cx.prompt(
	PromptLevel::Info,
	&format!("Delete {file_name:?}?"),
	None,
	&["Delete", "Cancel"],
	);

One could extend that Delete struct to accept prompt: boolean parameter and rework the action declaration similar to buffer_search::Delete:

zed/crates/search/src/buffer_search.rs

Lines 43 to 48 in dab886f

	#[derive(PartialEq, Clone, Deserialize)]
	pub struct Deploy {
	pub focus: bool,
	}
	impl_actions!(buffer_search, [Deploy]);

and then change the default keybindings (what was edited by the PR that tried to close this issue) to specify something like

"cmd-e": [
    "buffer_search::Deploy",
    {
        "focus": false
    }
],

but for the new case.

The most important part is to ensure that the old version, "delete": "project_panel::Delete", does still work and does the old, with confirmation query, deletion.
That is done via ensuring that the new field in project_panel::Delete will get a proper default value.

[shellscape]

Can you check your keybindings and ensure it's not the plain backspace that does nothing?

I've never modified them, but I do have this in the default bindings file:

      "delete": "project_panel::Delete",
      "cmd-backspace": "project_panel::Delete",

Although as stated above, the delete action does nothing on my machine. Glad to see there's a good fix possible!

[ConradIrwin]

This shipped to 0.128.0-pre and will hit stable next week

[shellscape]

@ConradIrwin appreciate getting this in! unfortunately this didn't fix the regression where delete/backspace (without the CMD key modifier) does bupkis. It "should" prompt for delete, but it doesn't.

[mayfieldiv]

@ConradIrwin appreciate getting this in! unfortunately this didn't fix the regression where delete/backspace (without the CMD key modifier) does bupkis. It "should" prompt for delete, but it doesn't.

I think this is finally fixed by #9590, which is in 0.129.0-pre

[shellscape]

@mayfieldiv @ConradIrwin y'all still don't have this quite right. Delete without the CMD modifier sends a file(s) to the trash with VSCode, and that's the desirable behavior. CMD+Delete is straight to the ether, no trash, do not collect $200 dollars.

[JosephTLyons]

@mayfieldiv @ConradIrwin y'all still don't have this quite right. Delete without the CMD modifier sends a file(s) to the trash with VSCode, and that's the desirable behavior. CMD+Delete is straight to the ether, no trash, do not collect $200 dollars.

Sounds like these things can be consolidated:

• Move files to system trash when deleting a file within Zed #5094