Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd+click symbol definition to find all references #5351

Closed
JosephTLyons opened this issue Jun 22, 2022 · 5 comments · Fixed by #9243
Closed

cmd+click symbol definition to find all references #5351

JosephTLyons opened this issue Jun 22, 2022 · 5 comments · Fixed by #9243
Assignees
Labels
editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label]

Comments

@JosephTLyons
Copy link
Contributor

JosephTLyons commented Jun 22, 2022

Being able to cmd+click on the usage of some symbol and jump to its definition has been implemented, but I would also like to be able to cmd+click on a definition to launch the Find All References action.

@JosephTLyons JosephTLyons added the enhancement [core label] label Jun 22, 2022
@mikayla-maki
Copy link
Contributor

Now this would be a hell of a feature.

@JosephTLyons
Copy link
Contributor Author

JosephTLyons commented Jun 22, 2022

Now this would be a hell of a feature.

The neat thing is, Zed already supports Find All References - it opens them up into a multi-buffer, so this would just be adding the frontend changes needed to turn the definition into a link on cmd-click, which should mostly be done once #120 lands. The code would just need to know if it is the definition of a symbol or the usage of the symbol, and then perform the correct action based on that.

@JosephTLyons JosephTLyons changed the title cmd+click symbol to find all references cmd+click symbol definition to find all references Jun 22, 2022
@mikayla-maki
Copy link
Contributor

Yeah, I use both of them extensively right now as I'm exploring the zed code base. It's really cool to think of the 'upstream' (go to definition) and 'downstream' (find all references) behaviors here as one unified action rather than two separate ones.

@mikayla-maki mikayla-maki mentioned this issue Dec 4, 2022
48 tasks
@JosephTLyons JosephTLyons added the editor Feedback for code editing, formatting, editor iterations, etc label Mar 14, 2023
@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@OgulcanCelik
Copy link

I tried Zed today for the first time and this is something that become muscle memory for me using VSCode, would be super helpful to have it on Zed for the intuitive migration process.

@xixixao
Copy link

xixixao commented Feb 29, 2024

Love the speed of Zed, but this is a must-have feature. Including showing the references in a popover instead of in a new tab.

Similarly I need project search in a sidebar (haven't figured out if that's already possible).

These are features I use every few seconds in VS Code. Will give Zed another try when these are implemented.

@SomeoneToIgnore SomeoneToIgnore self-assigned this Mar 11, 2024
SomeoneToIgnore added a commit that referenced this issue Mar 12, 2024
…buffer anchors (#9242)

FindAllReferences LSP requests might take a long time to complete, and
currently Zed allows multiple requests spawned concurrently for the same
Anchor in the multi buffer. That results in multiple search results'
multi buffers appearing, sometimes at once, which is not what we want.

Part of #5351 that helps to
reduce the amount of search results after clicks that did not resolve
instantly.


Release Notes:

- Improved FindAllReferences action by not allowing concurrent requests
for the same multi buffer source
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label]
Projects
None yet
5 participants