Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot select files in project panel with auto_reveal_entries set to false #7005

Closed
1 task done
KristalAlfred opened this issue Jan 29, 2024 · 2 comments
Closed
1 task done
Labels
defect [core label] project panel Feedback for files tree view setting Feedback for preferences, configuration, etc

Comments

@KristalAlfred
Copy link
Contributor

KristalAlfred commented Jan 29, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Not sure this an actual issue, but the behaviour is unexpected to me at least. Submitting this as an issue since navigating with keyboard works fine.

It seems like disabling the auto_reveal_entries setting also disables selecting files in the project pane with the cursor. Mostly a graphical issue, since the functionality of opening files works the same.

To reproduce:

  1. Set project_panel.auto_reveal_entries = false
  2. Try to click a file with the cursor

Loving Zed btw! :)

Environment

Zed: v0.119.20 (Zed)
OS: macOS 13.6.2
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

zed_screenrec_02.mov

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

@KristalAlfred KristalAlfred added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jan 29, 2024
@JosephTLyons
Copy link
Contributor

This feels like a bug to me, thanks @KristalAlfred for the report.

@JosephTLyons JosephTLyons added setting Feedback for preferences, configuration, etc project panel Feedback for files tree view and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 1, 2024
SomeoneToIgnore pushed a commit that referenced this issue Feb 2, 2024
Fixes #7003 and #7005.

Selecting as a reaction to actually opening a new item doesn’t seem
robust in all cases, the PR improves that.

Release Notes:

- Fixed missing project panel file selection in certain cases
@KristalAlfred
Copy link
Contributor Author

Fixed in #7245.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] project panel Feedback for files tree view setting Feedback for preferences, configuration, etc
Projects
None yet
Development

No branches or pull requests

2 participants