Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vim motion e/E is blocked by hint text #7046

Closed
1 task done
TENX-S opened this issue Jan 30, 2024 · 4 comments · Fixed by #11616
Closed
1 task done

Vim motion e/E is blocked by hint text #7046

TENX-S opened this issue Jan 30, 2024 · 4 comments · Fixed by #11616
Labels

Comments

@TENX-S
Copy link
Contributor

TENX-S commented Jan 30, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

Screen.Recording.2024-01-30.at.12.52.47.mov

If you disable the inlay hints:

Screen.Recording.2024-01-30.at.13.08.27.mov

Environment

Zed: v0.120.4 (Zed Preview)
OS: macOS 14.2.1
Memory: 8 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

@TENX-S TENX-S added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Jan 30, 2024
@TENX-S TENX-S changed the title Vim motion is blocked by hint text Vim motion e is blocked by hint text Jan 30, 2024
@TENX-S TENX-S changed the title Vim motion e is blocked by hint text Vim motion e/E is blocked by hint text Jan 30, 2024
@mrnugget mrnugget added the vim label Jan 30, 2024
@ConradIrwin
Copy link
Collaborator

Thanks for reporting this!

This is due to some of the helpers that vim motions currently use hitting the wrong layer of abstraction (the DisplayMap instead of the Buffer) when moving around. Fixing this will also help with a number of other edge cases around folding and soft-wraps too. I think we can fix this by moving the implementation of chars_at and reverse_chars_at on DisplayMap and providing a compatible API that reads from the Buffer directly.

If you (or anyone'd) like to pair on a fix, feel free to book time: https://calendly.com/conradirwin/pairing.

@JosephTLyons JosephTLyons removed triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 1, 2024
@Vagab
Copy link
Contributor

Vagab commented Apr 30, 2024

@ConradIrwin I think this is currently fixed in main, is it not?

@ConradIrwin
Copy link
Collaborator

Sadly not. I'm not sure why though, as I thought that would have fixed it.

Will happily pair if you want to!

@Vagab
Copy link
Contributor

Vagab commented Apr 30, 2024

Will happily pair if you want to!

let's do this!

ConradIrwin added a commit that referenced this issue May 9, 2024
Co-Authored-By: Sergey <sergey.b@hey.com>
Fixes: #7046
ConradIrwin added a commit that referenced this issue May 9, 2024
Co-Authored-By: Sergey <sergey.b@hey.com>
Fixes: #7046
ConradIrwin added a commit that referenced this issue May 9, 2024
Co-Authored-By: Sergey <sergey.b@hey.com>
Fixes: #7046

Release Notes:

- vim: Fixes e/E with inlay hints (#7046)

Co-authored-by: Sergey <sergey.b@hey.com>
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this issue May 18, 2024
Co-Authored-By: Sergey <sergey.b@hey.com>
Fixes: zed-industries#7046

Release Notes:

- vim: Fixes e/E with inlay hints (zed-industries#7046)

Co-authored-by: Sergey <sergey.b@hey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants