Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not disable completion documentation #7348

Closed
1 task done
failable opened this issue Feb 4, 2024 · 0 comments · Fixed by #7372
Closed
1 task done

Can not disable completion documentation #7348

failable opened this issue Feb 4, 2024 · 0 comments · Fixed by #7372
Labels
defect [core label] documentation [core label] popovers Feedback for tooltips, syntax hints, info popups, etc setting Feedback for preferences, configuration, etc

Comments

@failable
Copy link

failable commented Feb 4, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

  1. Start Zed.
  2. Set show_completion_documentation to false.
  3. Type some code.

Environment

Zed: v0.121.2 (Zed Preview)
OS: macOS 14.2.1
Memory: 32 GiB
Architecture: x86_64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screenshot 2024-02-04 at 11 36 40

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response
@failable failable added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Feb 4, 2024
mrnugget added a commit that referenced this issue Feb 5, 2024
@mrnugget
Do not show completion documentation if disabled
5840ff1 
This fixes #7348 by not rendering completions if they are disabled in
the settings. Previously we only checked that setting when starting or
not starting background threads to fetch documentation. But in case we
already have documentation, this stops it from being rendered.
@mrnugget mrnugget mentioned this issue Feb 5, 2024
Merged
mrnugget added a commit that referenced this issue Feb 5, 2024
@mrnugget
Do not show completion documentation if disabled (#7372)
87d3f59 
This fixes #7348 by not rendering completions if they are disabled in
the settings. Previously we only checked that setting when starting or
not starting background threads to fetch documentation. But in case we
already have documentation, this stops it from being rendered.

Release Notes:

- Fixed documentation in completions showing up even when disabled via
`show_completion_documentation`
([#7348](#7348))
@JosephTLyons JosephTLyons added documentation [core label] setting Feedback for preferences, configuration, etc popovers Feedback for tooltips, syntax hints, info popups, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] documentation [core label] popovers Feedback for tooltips, syntax hints, info popups, etc setting Feedback for preferences, configuration, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not show completion documentation if disabled zed-industries/zed
2 participants
@failable @JosephTLyons