Terminal: cursor doesn't blink until I press a key #7401
Comments
warpdesign
added
admin read
mrnugget
added
the
terminal
mrnugget
added a commit
that referenced
this issue
Feb 6, 2024
This fixes #7401 and probably a few other things that seemed odd with the terminal. Turns out that `TerminalView` has `focus_in` and `focus_out` callbacks, but they were never called. The `focus_handle` on which they were set was not passed in to `TerminalView`. That meant that the `impl FocusableView for TerminalView` never returned the focus handle with the right callbacks. This change here uses the already created focus handle and passes it in, so that `focus_in` and `focus_out` are now correctly called.
mrnugget
added a commit
that referenced
this issue
Feb 6, 2024
This fixes #7401 and probably a few other things that seemed odd with the terminal. Turns out that `TerminalView` has `focus_in` and `focus_out` callbacks, but they were never called. The `focus_handle` on which they were set was not passed in to `TerminalView`. That meant that the `impl FocusableView for TerminalView` never returned the focus handle with the right callbacks. This change here uses the already created focus handle and passes it in, so that `focus_in` and `focus_out` are now correctly called. Release Notes: - Fixed terminal not handling focus-state correctly and, for example, not restoring cursor blinking state correctly. ([#7401](#7401)).
|
Thanks for reporting! I fixed it in #7428, which will go out with a Preview release this week and a stable release next week (or maybe we'll cherry-pick before) |
JosephTLyons
added
setting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check for existing issues
Describe the bug / provide steps to reproduce it
I added this to the settings json:
And cursor doesn't blink unless I type something in the terminal.
Environment
Zed: v0.121.3 (Zed Preview)
OS: macOS 13.6.1
Memory: 8 GiB
Architecture: x86_64
If applicable, add mockups / screenshots to help explain present your vision of the feature
zed-terminal-blink.mov
If applicable, attach your
~/Library/Logs/Zed/Zed.logfile to this issue.If you only need the most recent lines, you can run the
zed: open logcommand palette action to see the last 1000.No response
The text was updated successfully, but these errors were encountered: