Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per project terminal.shell not working as documented #7599

Closed
1 task done
wesleycoder opened this issue Feb 9, 2024 · 2 comments · Fixed by #11526
Closed
1 task done

Per project terminal.shell not working as documented #7599

wesleycoder opened this issue Feb 9, 2024 · 2 comments · Fixed by #11526
Labels
defect [core label] setting Feedback for preferences, configuration, etc terminal Feedback for terminal integration, shell commands, etc

Comments

@wesleycoder
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

This is my first time trying zed, if I'm out of place let me know :)

I checked all the open issues and couldn't find anything directly related, #5320 seems a little bit related but is about a different symptom, so I decided continue with this issue.


I was trying to get tmux to open as zeds integrated terminal, (similar to this article for vscode).
With this I followed the zed's docs for configuring the terminal.

Configuring tmux worked at the user config level ~/.config/zed/settings.json, but not on a project level.

But with this I discovered that Zed isn't respecting the .zed/settings.json file created by the Zed > Settings > Open Local Settings command.

I wished to be able to set this on a per project level, because I couldn't get a dynamic name for the workspace (as the article for vscode suggests), this would be nice to have on Zed too, but of course is out of scope for this issue.

~/.config/zed/settings.json:

{
  "project_panel": {
    "dock": "right"
  },
  "theme": "Ayu Dark",
  "ui_font_size": 16,
  "buffer_font_size": 13
}

~/project_dir/.zed/settings.json:

{
  "terminal": {
    "shell": {
      "with_arguments": {
        "program": "tmux",
        "args": [
          "new",
          "-As",
          "zed"
        ]
      }
    }
  }
}

I've restarted the editor presuming a reload would fix, but no luck.
I've attached a recording of the process, but I reiterate that I'm newbie when it comes to zed config.

Environment

Zed: v0.121.7 (Zed)
OS: macOS 14.4.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

Screen.Recording.2024-02-08.at.22.44.31.mov

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

Zed.log file was too big for github to accept it inline (or inside a details tag), so i created a gist for it:
https://gist.githubusercontent.com/wesleycoder/f99800a8be42059c2a0a4501355c52fa/raw/6294e69dae943a0f6d8c180adb0a415275434df9/Zed.log

@wesleycoder wesleycoder added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Feb 9, 2024
@JosephTLyons JosephTLyons added terminal Feedback for terminal integration, shell commands, etc setting Feedback for preferences, configuration, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 9, 2024
@LoganDark
Copy link
Contributor

Just ran into this. Some of my projects are in WSL and need a project-specific shell or else I won't be able to execute any commands on them at all, since they're on the WSL filesystem. I can manually run wsl.exe -d whatever every time I start a terminal, but it would be a lot more helpful if Zed just respected the local settings instead.

LoganDark added a commit to LoganDark/zed that referenced this issue May 7, 2024
Allows you to define per-project shells, for example.

Fixes zed-industries#7599
@LoganDark
Copy link
Contributor

#11526

SomeoneToIgnore pushed a commit that referenced this issue May 8, 2024
…1526)

Fixes #7599

Use project level settings if possible, when creating terminals.

Release Notes:

- Fixed terminals ignoring project-specific settings ([7599](#7599))
osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this issue May 18, 2024
…d-industries#11526)

Fixes zed-industries#7599

Use project level settings if possible, when creating terminals.

Release Notes:

- Fixed terminals ignoring project-specific settings ([7599](zed-industries#7599))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] setting Feedback for preferences, configuration, etc terminal Feedback for terminal integration, shell commands, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants