Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow me to disable popup warning #8255

Closed
1 task done
nckre opened this issue Feb 23, 2024 · 2 comments · Fixed by #8312
Closed
1 task done

Allow me to disable popup warning #8255

nckre opened this issue Feb 23, 2024 · 2 comments · Fixed by #8312
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc setting Feedback for preferences, configuration, etc

Comments

@nckre
Copy link

nckre commented Feb 23, 2024

Check for existing issues

  • Completed

Describe the feature

CleanShot 2024-02-23 at 10 04 49

Not sure if this is a bug or expected behaviour. I copy+pasted some faulty code into my prisma.schema.

With each key stroke, I get a popup warning that I should switch the language server, making it hard to fix the code.

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@nckre nckre added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Feb 23, 2024
@jordanjones98
Copy link

#8229 is slightly related, Language Servers should show errors in the bottom bar not intrusive windows like this I think.

@JosephTLyons JosephTLyons added defect [core label] editor Feedback for code editing, formatting, editor iterations, etc setting Feedback for preferences, configuration, etc and removed enhancement [core label] triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 23, 2024
@mikayla-maki mikayla-maki mentioned this issue Feb 23, 2024
Merged
mikayla-maki added a commit that referenced this issue Feb 23, 2024
@mikayla-maki @maxdeviant
Switch LSP prompts to use a non-blocking toast (#8312)
cab8b5a 
This fixes a major degradation in usability that some users ran into.

Fixes #8255 
Fixes #8229

Release Notes:

- Switch from using platform prompts to toasts for LSP prompts.
([8255](#8255),
[8229](#8229))

<img width="583" alt="Screenshot 2024-02-23 at 2 40 05 PM"
src="https://github.com/zed-industries/zed/assets/2280405/1bfc027b-b7a8-4563-88b6-020e47869668">

Co-authored-by: Marshall <marshall@zed.dev>
SomeoneToIgnore pushed a commit that referenced this issue Feb 24, 2024
@mikayla-maki @maxdeviant @SomeoneToIgnore
Switch LSP prompts to use a non-blocking toast (#8312)
2b4e6e7 
This fixes a major degradation in usability that some users ran into.

Fixes #8255 
Fixes #8229

Release Notes:

- Switch from using platform prompts to toasts for LSP prompts.
([8255](#8255),
[8229](#8229))

<img width="583" alt="Screenshot 2024-02-23 at 2 40 05 PM"
src="https://github.com/zed-industries/zed/assets/2280405/1bfc027b-b7a8-4563-88b6-020e47869668">

Co-authored-by: Marshall <marshall@zed.dev>
@SomeoneToIgnore
Copy link
Contributor

Thanks to @mikayla-maki we did get rid of the blocking part of those notifications and this should be better now.
Zed Preview 0.124.5 was released with this fix, please provide more feedback if something is not working well here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] editor Feedback for code editing, formatting, editor iterations, etc setting Feedback for preferences, configuration, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch LSP prompts to use a non-blocking toast zed-industries/zed
4 participants
@SomeoneToIgnore @jordanjones98 @JosephTLyons @nckre