Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMD-P auto trigger #8258

Closed
1 task done
TudorEsan opened this issue Feb 23, 2024 · 5 comments
Closed
1 task done

CMD-P auto trigger #8258

TudorEsan opened this issue Feb 23, 2024 · 5 comments
Labels
command palette Feedback for the command palette enhancement [core label]

Comments

@TudorEsan
Copy link

TudorEsan commented Feb 23, 2024 •
edited

Check for existing issues

  • Completed

Describe the feature

Hi, it would be nice for the cmd-p to trigger automaticaly when i release it, just like vs code.

For now i have to cmd-p -> search the file -> press enter. This is a little bit slow
@TudorEsan TudorEsan added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Feb 23, 2024
@mrnugget
Copy link
Member

What exactly do you mean with release it? I can't reproduce the desired behavior in VS Code, I think.

@TudorEsan
Copy link
Author

TudorEsan commented Feb 23, 2024 •
edited

Hi @mrnugget sorry if i was not clear enough. So if I cmd+p and after that I cmd+p again if I release the cmd key I am directed the page that is currenlty selected. Hope it is clear now

PS I dont know if the video is helpfull but I included it 😄

Screen.Recording.2024-02-23.at.17.04.54.mov

@JosephTLyons JosephTLyons added command palette Feedback for the command palette and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Feb 23, 2024
@github-actions github-actions bot mentioned this issue Feb 24, 2024
Open
@Moshyfawn Moshyfawn mentioned this issue Mar 3, 2024
Closed
@alygin alygin mentioned this issue Mar 3, 2024
Merged
ConradIrwin pushed a commit that referenced this issue Mar 21, 2024
@alygin
Action release handlers (#8782)
5602c48 
This PR adds support for handling action releases — events that
are fired when the user releases all the modifier keys that were part of
an action-triggering shortcut.

If the user holds modifiers and invokes several actions sequentially via
shortcuts (same or different), only the last action is "released" when
its modifier keys released.

~The following methods were added to `Div`:~
- ~`capture_action_release()`~
- ~`on_action_release()`~
- ~`on_boxed_action_release()`~

~They work similarly to `capture_action()`, `on_action()` and
`on_boxed_action()`.~

See the implementation details in [this
comment](#8782 (comment)).

Release Notes:

- Added a fast-switch mode to the file finder: hit `p` or `shift-p`
while holding down `cmd` to select a file immediately. (#8258).

Related Issues:

- Implements #8757 
- Implements #8258
- Part of #7653 

Co-authored-by: @ConradIrwin
@alygin
Copy link
Contributor

alygin commented Mar 21, 2024 •
edited

@TudorEsan , @JosephTLyons , implementation is merged in #8782

@TudorEsan
Copy link
Author

one more question? do I need to activate it? because it is not working for me yet. Or is it not released yet with this feature?

@Moshyfawn
Copy link
Contributor

one more question? do I need to activate it? because it is not working for me yet. Or is it not released yet with this feature?

It hasn't been published yet. I'm guessing it'll be in the preview next week on Wednesday, if all goes to plan.

pjlast pushed a commit to pjlast/zed that referenced this issue Mar 26, 2024
@alygin @pjlast
Action release handlers (zed-industries#8782)
bc283bd 
This PR adds support for handling action releases — events that
are fired when the user releases all the modifier keys that were part of
an action-triggering shortcut.

If the user holds modifiers and invokes several actions sequentially via
shortcuts (same or different), only the last action is "released" when
its modifier keys released.

~The following methods were added to `Div`:~
- ~`capture_action_release()`~
- ~`on_action_release()`~
- ~`on_boxed_action_release()`~

~They work similarly to `capture_action()`, `on_action()` and
`on_boxed_action()`.~

See the implementation details in [this
comment](zed-industries#8782 (comment)).

Release Notes:

- Added a fast-switch mode to the file finder: hit `p` or `shift-p`
while holding down `cmd` to select a file immediately. (zed-industries#8258).

Related Issues:

- Implements zed-industries#8757 
- Implements zed-industries#8258
- Part of zed-industries#7653 

Co-authored-by: @ConradIrwin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
command palette Feedback for the command palette enhancement [core label]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mrnugget @alygin @Moshyfawn @JosephTLyons @TudorEsan