-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vim: Selection misses 1 character in Normal Mode #8492
Comments
After doing more testing, this happens only when using the mouse and selecting upward. I feel as if this is a bias issue, because it seem's like this problem appeared when visual mode was being implemented, and was only fixed for vim motions. It is described in a comment in I will look further for a fix or a direct cause. |
@bobby-burns happy to work with you on this if you'd like too: https://calendly.com/conradirwin/pairing; but I think you're right. The tricky thing may be knowing that the selection was recently created from a mouse event; but we may also be able to reasonable assume that's the only way to jump from normal mode to visual mode without using a vim command... |
@bobby-burns this also happens in plain |
I think he means selecting to the left ("upwards"), and not necessarily selecting across rows. EDIT: this dual behavior occurs only when the initially selected character is at the end of the line; we should probably consider implementing something similar for Zed as well. I think we also need to consider what the intended behavior should be. Screen.Recording.2024-03-22.at.11.23.06.AM.movThis video demonstrates VSCode's behavior with Vim mode, which, despite the |
Check for existing issues
Describe the bug / provide steps to reproduce it
In Vim (
Normal Mode
) - selecting the block of code misses one character always.In
insert mode
, it works fine.Check Following Screencast for explanation.
Environment
Zed: v0.123.6 (Zed)
OS: macOS 14.3.1
Memory: 16 GiB
Architecture: aarch64
If applicable, add mockups / screenshots to help explain present your vision of the feature
zed_wrong_selection.mp4
If applicable, attach your
~/Library/Logs/Zed/Zed.log
file to this issue.If you only need the most recent lines, you can run the
zed: open log
command palette action to see the last 1000.No response
The text was updated successfully, but these errors were encountered: