Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Use GitHub Copilot in Zed." popup freezes and does nothing #9596

Closed
1 task done
wzxu opened this issue Mar 20, 2024 · 7 comments
Closed
1 task done

"Use GitHub Copilot in Zed." popup freezes and does nothing #9596

wzxu opened this issue Mar 20, 2024 · 7 comments
Labels
ai Improvement related to Assistant, Copilot, or other AI features copilot AI feedback for Copilot defect [core label] regression A bug that was introduced in a recent release urgent Issue that needs immediate attention

Comments

@wzxu
Copy link

wzxu commented Mar 20, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

As title, when I hover the buttons they're highlighted, but clicking them does nothing.
Copy doesn't copy. Connect to GitHub doesn't open browser. Cancel doesn't dismiss the popup.
I've tried deleting everything including Zed config as well as GitHub login from the keychain and it's still the same.
Can't get Copilot to work due to this.
13461

Environment

Zed: v0.128.0 (Zed Preview)
OS: macOS 14.4.0
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@wzxu wzxu added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Mar 20, 2024
@Moshyfawn Moshyfawn added copilot AI feedback for Copilot ai Improvement related to Assistant, Copilot, or other AI features and removed triage Maintainer needs to classify the issue labels Mar 20, 2024
@Moshyfawn Moshyfawn added the urgent Issue that needs immediate attention label Mar 20, 2024
@Moshyfawn
Copy link
Contributor

Have you noticed anything strange in the Zed logs when you try to login/activate Copilot zed: open log?

@tekacs
Copy link

tekacs commented Mar 21, 2024

Could this be because of the following code in this change in the latest release, a fix to #8852?

            .capture_any_mouse_down(cx.listener(|this, _: &MouseDownEvent, cx| {
                cx.focus(&this.focus_handle);
                cx.stop_propagation();
            }))

From #9217

@Moshyfawn
Copy link
Contributor

Sounds like it, as there are no events or errors in the logs.

@Moshyfawn Moshyfawn added the regression A bug that was introduced in a recent release label Mar 21, 2024
ConradIrwin added a commit that referenced this issue Mar 21, 2024
Release Notes:

- Fixed copilot modal not responding
([#9596](#9596)). (preview
only)
gcp-cherry-pick-bot bot pushed a commit that referenced this issue Mar 21, 2024
Release Notes:

- Fixed copilot modal not responding
([#9596](#9596)). (preview
only)
ConradIrwin added a commit that referenced this issue Mar 21, 2024
Cherry-picked Fix copilot modal (#9613)

Release Notes:

- Fixed copilot modal not responding
([#9596](#9596)). (preview
only)

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
@ConradIrwin
Copy link
Collaborator

Fixed in 0.128.1, thanks for the fast report!

@haeussma
Copy link

Have the described issue in 0.128.3.

2024-03-21T19:58:46+01:00 [WARN] Generic lsp request to node failed: Unhandled method textDocument/definition
2024-03-21T19:58:47+01:00 [INFO] Language server with id 1 sent unhandled notification client/unregisterCapability:
{
  "unregisterations": [
    {
      "id": "44a46941-a1ff-4c67-b044-81b6776343e9",
      "method": "workspace/didChangeWatchedFiles"
    }
  ]
}
2024-03-21T19:58:47+01:00 [INFO] Node runtime install_if_needed
2024-03-21T19:58:48+01:00 [INFO] starting language server. binary path: "/Users/max/Library/Application Support/Zed/node/node-v18.15.0-darwin-arm64/bin/node", working directory: "/", args: ["/Users/max/Library/Application Support/Zed/copilot/copilot-v0.5.0/dist/agent.js", "--stdio"]
2024-03-21T19:58:48+01:00 [INFO] Language server with id 0 sent unhandled notification LogMessage:
{
  "level": 0,
  "message": "[DEBUG] [agent] [2024-03-21T18:58:48.357Z] Agent service starting",
  "metadataStr": "[DEBUG] [agent] [2024-03-21T18:58:48.357Z]",
  "extra": [
    "Agent service starting"
  ]
}
2024-03-21T19:58:48+01:00 [INFO] Language server with id 0 sent unhandled notification client/registerCapability:
{
  "registrations": [
    {
      "id": "185fff1f-1d93-48f1-bd61-5259022160f3",
      "method": "workspace/didChangeWorkspaceFolders",
      "registerOptions": {}
    }
  ]
}
2024-03-21T19:58:48+01:00 [INFO] Language server with id 0 sent unhandled notification LogMessage:
{
  "level": 0,
  "message": "[DEBUG] [agent] [2024-03-21T18:58:48.365Z] Telemetry initialized",
  "metadataStr": "[DEBUG] [agent] [2024-03-21T18:58:48.365Z]",
  "extra": [
    "Telemetry initialized"
  ]
}
2024-03-21T19:59:09+01:00 [ERROR] Cancelled LSP request task for "signInConfirm" id 9 which took over 120s
2024-03-21T19:59:09+01:00 [ERROR] crates/lsp/src/lsp.rs:720: oneshot canceled
2024-03-21T20:01:06+01:00 [ERROR] Cancelled LSP request task for "signInConfirm" id 5 which took over 120s
2024-03-21T20:01:15+01:00 [ERROR] Cancelled LSP request task for "signInConfirm" id 7 which took over 120s

@Moshyfawn
Copy link
Contributor

Moshyfawn commented Mar 21, 2024

@haeussma, would you mind double checking the version you're running by selecting zed: about in the Command Palette? The latest version is 0.128.1 where this issue was fixed, and the last version with patch number 3 was 0.127.3.

MatthiasGrandl pushed a commit to MatthiasGrandl/zed that referenced this issue Mar 22, 2024
Release Notes:

- Fixed copilot modal not responding
([zed-industries#9596](zed-industries#9596)). (preview
only)
mikayla-maki pushed a commit that referenced this issue Mar 24, 2024
Release Notes:

- Fixed copilot modal not responding
([#9596](#9596)). (preview
only)
@Moshyfawn
Copy link
Contributor

The fix was also brought into Stable in v0.127.4.

pjlast pushed a commit to pjlast/zed that referenced this issue Mar 26, 2024
Release Notes:

- Fixed copilot modal not responding
([zed-industries#9596](zed-industries#9596)). (preview
only)
@JosephTLyons JosephTLyons removed the admin read Pending admin review label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai Improvement related to Assistant, Copilot, or other AI features copilot AI feedback for Copilot defect [core label] regression A bug that was introduced in a recent release urgent Issue that needs immediate attention
Projects
None yet
Development

No branches or pull requests

6 participants