Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-focused windows don't show hover state for clickable areas. #9784

Closed
mikayla-maki opened this issue Mar 25, 2024 · 0 comments · Fixed by #10229
Closed

Non-focused windows don't show hover state for clickable areas. #9784

mikayla-maki opened this issue Mar 25, 2024 · 0 comments · Fixed by #10229
Labels
defect [core label] good first issue Issue suitable for first-time contributors mouse interaction Feedback for mouse interaction states, actions, etc workspace Feedback for workspace management, layout, interactions, etc

Comments

@mikayla-maki
Copy link
Contributor

mikayla-maki commented Mar 25, 2024 •
edited

In #9553, support was added for responding to the first mouse click on a window, this is a common behavior in many apps, such as Firefox's browser tabs.

However, those implementations often show whether the UI element being hovered will respond to the mouse. As of this writing, Zed does not show this state.
@mikayla-maki mikayla-maki added defect [core label] triage Maintainer needs to classify the issue good first issue Issue suitable for first-time contributors admin read Pending admin review labels Mar 25, 2024
@mikayla-maki mikayla-maki changed the title Not-focused windows don't show hover state. Non-focused windows don't show hover state. Mar 25, 2024
@mikayla-maki mikayla-maki changed the title Non-focused windows don't show hover state. Non-focused windows don't show hover state for clickable areas. Mar 25, 2024
@JosephTLyons JosephTLyons added workspace Feedback for workspace management, layout, interactions, etc mouse interaction Feedback for mouse interaction states, actions, etc and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Mar 26, 2024
@weartist weartist mentioned this issue Apr 6, 2024
Merged
as-cii pushed a commit that referenced this issue Apr 24, 2024
@weartist
Enable unfocused windows to update their status based on whether they…
135a5f2 
… are clickable or not (#10229)

- Fixed #9784 By removing the interception of the MouseMove event, zed
can update the corresponding Hover even when it is inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] good first issue Issue suitable for first-time contributors mouse interaction Feedback for mouse interaction states, actions, etc workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Milestone
No milestone
2 participants
@mikayla-maki @JosephTLyons